Skip to content

Conversation

@luohoufu
Copy link
Contributor

What does this PR do

This pull request includes several changes to the config/setup/easysearch/template_rollup.tpl file to update Elasticsearch rollup jobs and settings, as well as a minor version check update in plugin/setup/setup.go. The most important changes include updating the endpoints for rollup jobs, adding new metrics and settings, and enabling rollup search.

Updates to rollup jobs and settings:

  • Updated endpoints for rollup jobs to include leading slashes (DELETE /_rollup/jobs/rollup_index_stats, PUT /_rollup/jobs/rollup_index_stats, etc.) [1] [2] [3] [4] [5] [6] [7].
  • Added new metrics such as min and special_metrics for rollup jobs (PUT _rollup/jobs/rollup_index_stats?replace, PUT _rollup/jobs/rollup_node_stats?replace, PUT _rollup/jobs/rollup_shard_stats_metrics?replace) [1] [2] [3].
  • Enabled rollup search and updated index settings (PUT /_cluster/settings, PUT /.easysearch-ilm-config/_settings).

Codebase update:

  • Updated version check in plugin/setup/setup.go to compare against version 1.10.0 instead of 1.9.2 for initializing rollup templates.

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@luohoufu luohoufu requested a review from silenceqi January 23, 2025 11:46
Copy link
Contributor

@silenceqi silenceqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silenceqi silenceqi merged commit 67447b8 into main Jan 23, 2025
6 checks passed
@silenceqi silenceqi deleted the update_rollup_pr branch January 23, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants