Skip to content

Add generic typings #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thabalija wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add generic typings #47

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df2edd3
Add genetic typings
thabalija Feb 28, 2022
c07b556
Bump changelog version
thabalija Feb 28, 2022
a063477
Update projects/ngx-form-object/src/lib/form-object-builder/form-obje…
thabalija Mar 1, 2022
9c02938
Make form object builder reusable
thabalija Mar 8, 2022
047bab3
Update CHANGELOG.md
thabalija Mar 8, 2022
088283a
Tweak types when creating form fields
safo6m Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make form object builder reusable
  • Loading branch information
@thabalija @safo6m
thabalija authored and safo6m committed Jan 15, 2025
commit 9c0293838cbabdd806936b6cc824043078ac3149
16 changes: 8 additions & 8 deletions projects/ngx-form-object/src/lib/form-object-builder/form-object-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ import { capitalize } from '../helpers/helpers';
import { PropertyOptions } from '../interfaces/property-options.interface';
import { CREATE_FORM_OBJECT_METHODS, MODEL_BUILD_CONTROL_METHODS } from '../types/model-metadata.type';

export class FormObjectBuilder<T> {
export class FormObjectBuilder {
public formBuilder: FormBuilder;

constructor() {
this.formBuilder = new FormBuilder();
}

public create(formObject: FormObject<T>): FormStore<T> {
public create<T>(formObject: FormObject<T>): FormStore<T> {
const formFields: Record<string, AbstractControl> = {};

Object.assign(formFields, this.createAttributeFormFields(formObject));
Expand All @@ -33,7 +33,7 @@ export class FormObjectBuilder<T> {
return formStore;
}

private createAttributeFormFields(formObject: FormObject<T>): object {
private createAttributeFormFields<T>(formObject: FormObject<T>): object {
const attributeFormFields: Record<string, AbstractControl> = {};

formObject.attributePropertiesKeys.forEach((attributeName: string) => {
Expand All @@ -53,7 +53,7 @@ export class FormObjectBuilder<T> {
return attributeFormFields;
}

private createHasManyFormFields(formObject: FormObject<T>): object {
private createHasManyFormFields<T>(formObject: FormObject<T>): object {
const hasManyFormFields: Record<string, AbstractControl> = {};

formObject.hasManyPropertiesKeys.forEach((propertyName: string) => {
Expand All @@ -70,7 +70,7 @@ export class FormObjectBuilder<T> {
return hasManyFormFields;
}

private createBelongsToFormFields(formObject: FormObject<T>): object {
private createBelongsToFormFields<T>(formObject: FormObject<T>): object {
const belongsToFormFields = {};

formObject.belongsToPropertiesKeys.forEach((propertyName: string | symbol) => {
Expand Down Expand Up @@ -104,7 +104,7 @@ export class FormObjectBuilder<T> {
return belongsToFormFields;
}

private getBuildFunction(formObject: FormObject<T>, propertyName: string | symbol): () => AbstractControl {
private getBuildFunction<T>(formObject: FormObject<T>, propertyName: string | symbol): () => AbstractControl {
const propertyNameString = propertyName.toString();

// Deprecated in favour of build control decorator
Expand All @@ -117,7 +117,7 @@ export class FormObjectBuilder<T> {
return buildFunction;
}

private buildRelationshipModels(
private buildRelationshipModels<T>(
formObject: FormObject<T>,
relationshipName: string | symbol,
relationshipModels: Array<any> = [],
Expand Down Expand Up @@ -147,7 +147,7 @@ export class FormObjectBuilder<T> {
return relationshipFormGroups;
}

private createRelationshipFormObject(
private createRelationshipFormObject<T>(
formObject: FormObject<T>,
relationshipName: string | symbol,
relationshipModel: any,
Expand Down