Skip to content

feat(inputs.nftables): Add plugin#17604

Merged
skartikey merged 29 commits intoinfluxdata:masterfrom
ansoni:master
Nov 20, 2025
Merged

feat(inputs.nftables): Add plugin#17604
skartikey merged 29 commits intoinfluxdata:masterfrom
ansoni:master

Conversation

@ansoni
Copy link
Copy Markdown
Contributor

@ansoni ansoni commented Sep 8, 2025 •
edited by srebhan
Loading

Summary

Add an nftables input plugin for polling the linux firewall rule byte and packet counters. Telegraf has support for the older iptables, but not nftables. This new plugin tries to stay consistent with the iptables usage and outputs.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #8424

@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Sep 8, 2025

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@ajohnson-aurora
Copy link
Copy Markdown
Contributor

ajohnson-aurora commented Sep 9, 2025

!signed-cla

@ansoni ansoni changed the title Add nftables input plugin feat(inputs.nftables): Add nftables input plugin Sep 18, 2025
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 18, 2025
skartikey
skartikey reviewed Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ansoni Thanks for the contribution! I've left some initial review comments for your consideration. Could you also run make lint and address any linter issues that come up?

@skartikey skartikey self-assigned this Sep 19, 2025
@ansoni ansoni requested a review from skartikey September 23, 2025 18:27
@ansoni
Copy link
Copy Markdown
Contributor Author

ansoni commented Sep 23, 2025 •
edited
Loading

Linters and changes should all be good. The Lint Code Base job seems broken with a 403 error.

@ansoni
Copy link
Copy Markdown
Contributor Author

ansoni commented Sep 26, 2025

@skartikey When you get a second, please take a look. I'm not sure how I can fix that Lint Code Base job.

@skartikey
Copy link
Copy Markdown
Contributor

skartikey commented Oct 3, 2025

@skartikey When you get a second, please take a look. I'm not sure how I can fix that Lint Code Base job.

@ansoni That issue isn’t related to your change, so you can ignore it. We’ll put up a fix for the Lint Code Base job separately.

skartikey
skartikey reviewed Oct 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ansoni Thanks! Some more comments.

@skartikey skartikey added the waiting for response waiting for response from contributor label Oct 3, 2025
@ansoni ansoni requested a review from skartikey October 7, 2025 01:16
@srebhan srebhan removed the waiting for response waiting for response from contributor label Oct 7, 2025
@srebhan srebhan changed the title feat(inputs.nftables): Add nftables input plugin feat(inputs.nftables): Add plugin Oct 7, 2025
skartikey
skartikey reviewed Oct 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ansoni Thanks for going through all the comments!
We’re almost there; just a few more notes to review. Please take a look.

@ansoni ansoni requested a review from skartikey October 7, 2025 21:07
@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Nov 12, 2025
@srebhan srebhan added the waiting for response waiting for response from contributor label Nov 12, 2025
@srebhan srebhan removed the waiting for response waiting for response from contributor label Nov 13, 2025
srebhan
srebhan approved these changes Nov 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ansoni! I took the liberty to fix the remaining comments and rework tests a bit...

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 13, 2025
@srebhan srebhan assigned skartikey and mstrandboge and unassigned srebhan Nov 13, 2025
skartikey
skartikey reviewed Nov 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Thanks for working on this PR, it’s getting very close to completion. Just a couple of minor points:

The test case directory name non_existant_table has a small typo - “existant” should be “existent.”

@ansoni
Copy link
Copy Markdown
Contributor Author

ansoni commented Nov 13, 2025

@srebhan Thank you! I have been crazy busy. Not sure how code gets merged after approval (I don't have a merge button)

@srebhan
Copy link
Copy Markdown
Member

srebhan commented Nov 17, 2025

@ansoni the merge process is the following: You need to get two approvals from the maintainers. You have mine and @skartikey does the second review. To get things merged you need to address his comments... If you cannot find the time and you are fine with it, please let me know and I can drive this PR over the finish line as I really want it to be included in v1.37.0.

@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Nov 19, 2025

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@skartikey skartikey merged commit 3ed5e05 into influxdata:master Nov 20, 2025
25 of 27 checks passed
@github-actions github-actions bot added this to the v1.37.0 milestone Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skartikey skartikey skartikey approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@skartikey skartikey

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

v1.37.0

Development

Successfully merging this pull request may close these issues.

Add nftables Input Plugin

5 participants

@ansoni @ajohnson-aurora @skartikey @srebhan @mstrandboge