Skip to content

feat(outputs.heartbeat): Add configuration information#18062

Merged
mstrandboge merged 4 commits intoinfluxdata:masterfrom
srebhan:output_heartbeat_minimal
Dec 2, 2025
Merged

feat(outputs.heartbeat): Add configuration information#18062
mstrandboge merged 4 commits intoinfluxdata:masterfrom
srebhan:output_heartbeat_minimal

Conversation

@srebhan
Copy link
Copy Markdown
Member

@srebhan srebhan commented Nov 25, 2025

Summary

This PR adds an option to send configuration information with the heartbeat i.e. the sources used to start the present configuration instance.

Checklist

Related issues

related to #17303

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Nov 25, 2025
Copy link
Copy Markdown
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Thanks!

@srebhan srebhan requested a review from skartikey November 26, 2025 20:35
@skartikey skartikey assigned mstrandboge and unassigned skartikey Nov 26, 2025
@skartikey skartikey added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 26, 2025
Copy link
Copy Markdown
Member

@mstrandboge mstrandboge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Just a couple comments on the testdata and readme

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these empty testdata files intentionally empty or are they meant to have something in them?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's correct. Those files are only there to mock filling the configurations list in config...

srebhan and others added 2 commits December 2, 2025 16:17
Co-authored-by: Maya Strandboge <136023093+mstrandboge@users.noreply.github.com>
Co-authored-by: Maya Strandboge <136023093+mstrandboge@users.noreply.github.com>
@srebhan srebhan requested a review from mstrandboge December 2, 2025 15:18
@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Dec 2, 2025

@mstrandboge mstrandboge merged commit 1abfbc0 into influxdata:master Dec 2, 2025
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.37.0 milestone Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants