fix(inputs.disk): Preserve device tag for virtual filesystems#18335
Merged
srebhan merged 2 commits intoinfluxdata:masterfrom Feb 16, 2026
Merged
fix(inputs.disk): Preserve device tag for virtual filesystems#18335srebhan merged 2 commits intoinfluxdata:masterfrom
srebhan merged 2 commits intoinfluxdata:masterfrom
Conversation
gopsutil v4.26.1 changed disk.Partitions() to return "none" as the device for virtual filesystems (tmpfs, sysfs, etc.) instead of the mount source name. Fall back to the filesystem type when the device is "none" or empty to maintain backwards compatibility.
telegraf-tiger
bot
added
fix
skartikey
changed the title
…ystems Cover both "none" and empty device name cases to verify that the fstype fallback preserves backwards compatibility with gopsutil v4.26.1.
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
mstrandboge
approved these changes
Feb 12, 2026
Member
mstrandboge
left a comment
mstrandboge
left a comment
There was a problem hiding this comment.
Backwards compatibility patch looks good, thanks for looking into this!
mstrandboge
added
the
ready for final review
mstrandboge
pushed a commit
that referenced
this pull request
Feb 23, 2026
(cherry picked from commit 3b2d17c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disk.Partitions()to returnDevice="none"for virtual filesystems (tmpfs, sysfs, devtmpfs, etc.) where the mount source doesn't start with/devicemetric tag to change from e.g.device=tmpfstodevice=none, breaking user dashboards and queries that filter on this tagFstypewhen the device is"none"or empty, preserving backwards compatibilityOpened upstream: shirou/gopsutil#2001
Checklist
Related issues
resolves #18293