fix(outputs.opentelemetry): Prevent goroutine leak on gzip write failure#18418
Merged
mstrandboge merged 2 commits intoinfluxdata:masterfrom Mar 2, 2026
Merged
Conversation
Hipska
reviewed
Feb 27, 2026
srebhan
reviewed
Feb 27, 2026
Member
srebhan
left a comment
There was a problem hiding this comment.
@skartikey I agree with @Hipska's comment, please directly assign to reader.
srebhan
approved these changes
Feb 27, 2026
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Hipska
approved these changes
Feb 27, 2026
mstrandboge
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close the gzip pipe reader returned by
CompressWithGzipinExport.If the HTTP request fails or the server responds before consuming the full body, the gzip goroutine can block on
PipeWriter.Write, causing a memory leak.While reviewing #18416 (which fixed this in
outputs.influxdb), I checked otherCompressWithGzipcall sites.outputs.opentelemetrywas the only remaining caller missing the close. Other plugins (outputs.http,outputs.sensu,outputs.loki) already usedefer rc.Close().Related to #18413, #18416
Checklist
Related issues
resolves #