Fix parameter order mismatch in site_diversity_rain_outage_probability (closes #86)#101
Merged
inigodelportillo merged 2 commits intomasterfrom Mar 2, 2026
Merged
Fix parameter order mismatch in site_diversity_rain_outage_probability (closes #86)#101inigodelportillo merged 2 commits intomasterfrom
inigodelportillo merged 2 commits intomasterfrom
Conversation
…y (ITU-618) The elevation angles el1/el2 were placed after f in _ITU618_13's method signature, inconsistent with the public API and __model wrapper. The public function call also passed args in the wrong order to __model. Fixes #86 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…#86) Adds test_site_diversity_regression to ITUR618_13TestCase covering: - Symmetric and asymmetric attenuation threshold cases - A swap check that confirms el1/el2 are correctly bound to their respective stations, guarding against reintroduction of the parameter order bug fixed in issue #86 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a parameter order mismatch bug in
site_diversity_rain_outage_probabilitywhere elevation anglesel1/el2were placed afterfin the_ITU618_13method signature, inconsistent with the public API and__modelwrapper. The public function call also passed arguments to__modelin the wrong order.This bug could cause incorrect calculations when the two sites have different elevation angles.
Closes #86
Changes
_ITU618_13.site_diversity_rain_outage_probabilityparameter order to match public API:lat1, lon1, a1, el1, lat2, lon2, a2, el2, f, tau, hs1, hs2__modelTest plan
python3 -m unittest test.ITU_validation_test.ITUR618_13TestCase.test_site_diversity_regression🤖 Generated with Claude Code