ADR-012 Standardise CLI multiple choice flags construction #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/ADR-012
branch
from
02d0b60 to
0129960
Compare
carbolymer
reviewed
Apr 15, 2025
docs/ADR-012-standardise-CLI-multiple-choice-flags-construction.md
Outdated
Show resolved
Hide resolved
carbolymer
reviewed
Apr 15, 2025
docs/ADR-012-standardise-CLI-multiple-choice-flags-construction.md
Outdated
Show resolved
Hide resolved
carbolymer
reviewed
Apr 15, 2025
docs/ADR-012-standardise-CLI-multiple-choice-flags-construction.md
Outdated
Show resolved
Hide resolved
carbolymer
reviewed
Apr 15, 2025
| fmap QueryUTxOCmd $ | ||
| QueryUTxOCmdArgs | ||
| <$> ... | ||
| <*> parserFromFormatFlags |
Collaborator
There was a problem hiding this comment.
carbolymer
reviewed
Apr 15, 2025
Collaborator
carbolymer
left a comment
carbolymer
left a comment
There was a problem hiding this comment.
LGTM! I think we should merge this at the same time as IntersectMBO/cardano-cli#1133, after we work out the details, since both describe the same thing.
carbolymer
reviewed
Apr 15, 2025
| ) | ||
| & onLeft (left . QueryCmdAcquireFailure) | ||
| & onLeft left | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Very good illustration of the problem!
Jimbo4350
approved these changes
Apr 15, 2025
Collaborator
Jimbo4350
left a comment
Jimbo4350
left a comment
There was a problem hiding this comment.
LGTM 👍
Can you touch base with @olgahryniuk to improve the formatting?
docs/ADR-012-standardise-CLI-multiple-choice-flags-construction.md
Outdated
Show resolved
Hide resolved
docs/ADR-012-standardise-CLI-multiple-choice-flags-construction.md
Outdated
Show resolved
Hide resolved
docs/ADR-012-standardise-CLI-multiple-choice-flags-construction.md
Outdated
Show resolved
Hide resolved
|
|
||
| ## Do not allow more than one default | ||
|
|
||
| There should be no more than one default and it should be fixed and visible from the help. |
newhoggy
force-pushed
the
newhoggy/ADR-012
branch
from
0129960 to
09a7f8d
Compare
newhoggy
force-pushed
the
newhoggy/ADR-012
branch
from
09a7f8d to
e955576
Compare
This was referenced May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.