Skip to content

fix: NPG-5347 Apply security best practices #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

fix: NPG-5347 Apply security best practices #286

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
544ee3e
- Apply security best practices
step-security-bot Mar 3, 2023
8e1af7d
chore: Update dependabot
minikin Mar 3, 2023
6286ea9
Update gh-pages.yml
minikin Mar 6, 2023
19a37d1
Update nix.yml
minikin Mar 6, 2023
0e4cab6
Merge branch 'main' into stepsecurity_remediation_1677854071
minikin Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update nix.yml
  • Loading branch information
@minikin
minikin committed Mar 6, 2023
commit 19a37d1915670cd86f82cb01aa5b95cb03a17a73
36 changes: 8 additions & 28 deletions .github/workflows/nix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,8 @@ jobs:
concurrency:
group: ${{ github.workflow }}
steps:
- name: Harden Runner
uses: step-security/harden-runner@c8454efe5d0bdefd25384362fe217428ca277d57 # v2.2.0
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

- name: Standard Discovery
uses: divnix/std-action/discover@ee2bde0566b88637cbf47b8efedb6a5063caadd1 # v0.0.4
uses: divnix/std-action/[email protected]
id: discovery
build-packages:
needs: discover
Expand All @@ -59,17 +54,12 @@ jobs:
name: ${{ matrix.target.cell }} - ${{ matrix.target.name }}
runs-on: ubuntu-latest
steps:
- name: Harden Runner
uses: step-security/harden-runner@c8454efe5d0bdefd25384362fe217428ca277d57 # v2.2.0
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@67fbcbb121271f7775d2e7715933280b06314838 # v1.7.0
uses: aws-actions/[email protected]
with:
role-to-assume: ${{ env.AWS_ROLE_ARN }}
aws-region: ${{ env.AWS_REGION }}
- uses: divnix/std-action/run@ee2bde0566b88637cbf47b8efedb6a5063caadd1 # v0.0.4
- uses: divnix/std-action/[email protected]
with:
extra_nix_config: |
${{ needs.discover.outputs.nix_conf }}
Expand All @@ -85,17 +75,12 @@ jobs:
name: ${{ matrix.target.cell }} - ${{ matrix.target.name }}
runs-on: ubuntu-latest
steps:
- name: Harden Runner
uses: step-security/harden-runner@c8454efe5d0bdefd25384362fe217428ca277d57 # v2.2.0
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@67fbcbb121271f7775d2e7715933280b06314838 # v1.7.0
uses: aws-actions/[email protected]
with:
role-to-assume: ${{ env.AWS_ROLE_ARN }}
aws-region: ${{ env.AWS_REGION }}
- uses: divnix/std-action/run@ee2bde0566b88637cbf47b8efedb6a5063caadd1 # v0.0.4
- uses: divnix/std-action/[email protected]
with:
extra_nix_config: |
${{ needs.discover.outputs.nix_conf }}
Expand All @@ -114,23 +99,18 @@ jobs:
name: ${{ matrix.target.cell }} - ${{ matrix.target.name }}
runs-on: ubuntu-latest
steps:
- name: Harden Runner
uses: step-security/harden-runner@c8454efe5d0bdefd25384362fe217428ca277d57 # v2.2.0
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@67fbcbb121271f7775d2e7715933280b06314838 # v1.7.0
uses: aws-actions/[email protected]
with:
role-to-assume: ${{ env.AWS_ROLE_ARN }}
aws-region: ${{ env.AWS_REGION }}
- name: Configure Registry
run: |
aws ecr get-login-password --region eu-central-1 | docker login --username AWS --password-stdin "${{ env.ECR_REGISTRY }}"
- uses: divnix/std-action/run@ee2bde0566b88637cbf47b8efedb6a5063caadd1 # v0.0.4
- uses: divnix/std-action/[email protected]
with:
extra_nix_config: |
${{ needs.discover.outputs.nix_conf }}
json: ${{ toJSON(matrix.target) }}
nix_key: ${{ secrets.NIX_SIGNING_KEY }}
cache: ${{ env.S3_CACHE }}
cache: ${{ env.S3_CACHE }}