Skip to content

Adds Firebase API read-through caching (fixes #25) #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NekR merged 1 commit into from
Apr 26, 2016
Merged

Adds Firebase API read-through caching (fixes #25) #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add support for Firebase API read-through caching 
This change adds support for https://github.com/GoogleChrome/firetruck,
a simple POC read-through caching adapter on top of the Firebase API.
  • Loading branch information
@addyosmani
addyosmani committed Apr 25, 2016
commit 6f05fe2fe78f418c143f0b7ee66123173fd55850
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"dependencies": {
"events": "1.1.0",
"firebase": "2.4.2",
"firetruck.js": "^0.1.1",
"history": "2.0.1",
"react": "15.0.1",
"react-dom": "15.0.1",
Expand Down
5 changes: 3 additions & 2 deletions src/services/HNService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
var Firebase = require('firebase')
var Firetruck = require('firetruck.js')

var api = new Firebase('https://hacker-news.firebaseio.com/v0')
var api = new Firetruck('https://hacker-news.firebaseio.com/v0')
api.restore()

function fetchItem(id, cb) {
itemRef(id).once('value', function(snapshot) {
Expand Down