Skip to content

Introduce Offline Mode #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
addyosmani merged 11 commits into from
May 17, 2016
Merged

Introduce Offline Mode #36

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fbaea43
Offline mode: Add REST-based HNService fallback
addyosmani May 9, 2016
e0a2eda
Offline mode: enable for Comments
addyosmani May 9, 2016
710c131
Offline mode: enable for items
addyosmani May 9, 2016
995b30f
Offline mode: enable for stories
addyosmani May 9, 2016
83ebc1b
Offline mode: enable for permalink comments
addyosmani May 9, 2016
fffe05e
Correct linting for runtime-caching
addyosmani May 9, 2016
240f39c
Offline mode: enable for updates
addyosmani May 9, 2016
82ddd1d
Offline mode: expose UI/option in Settings panel
addyosmani May 9, 2016
904546a
Offline mode: Add isomorphic-fetch for Fetch API use
addyosmani May 9, 2016
1a47287
Housekeeping: localise linting (avoid break w/global eslint)
addyosmani May 9, 2016
b81ecaf
Update offline mode text
addyosmani May 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Offline mode: enable for permalink comments
  • Loading branch information
@addyosmani
addyosmani committed May 9, 2016
commit 83ebc1b4fa9e03c38476bc6f07b036d3404efa67
12 changes: 11 additions & 1 deletion src/PermalinkedComment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ var withRouter = require('react-router/lib/withRouter')

var CommentThreadStore = require('./stores/CommentThreadStore')
var HNService = require('./services/HNService')
var HNServiceRest = require('./services/HNServiceRest')
var SettingsStore = require('./stores/SettingsStore')
var UpdatesStore = require('./stores/UpdatesStore')

Expand Down Expand Up @@ -32,7 +33,16 @@ var PermalinkedComment = React.createClass({
},

componentWillMount() {
this.bindAsObject(HNService.itemRef(this.props.params.id), 'comment')
if (SettingsStore.offlineMode) {
HNServiceRest.itemRef(this.props.params.id).then(function(res) {
return res.json()
}).then(function(snapshot) {
this.replaceState({ comment: snapshot })
}.bind(this))
}
else {
this.bindAsObject(HNService.itemRef(this.props.params.id), 'comment')
}
if (this.state.comment.id) {
this.commentLoaded(this.state.comment)
}
Expand Down