Skip to content

add id and className props for textarea #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mzabriskie merged 2 commits into from
Nov 5, 2015
Merged

add id and className props for textarea #14

mzabriskie merged 2 commits into from
Nov 5, 2015

Conversation

@mikenomitch
Copy link
Contributor

@mikenomitch mikenomitch commented Nov 5, 2015

No description provided.

@mzabriskie
Copy link
Contributor

mzabriskie commented Nov 5, 2015

Couple minor changes:

  • Resolve merge conflicts
  • Remove textarea from prop names: id, className.
  • Add componentWillReceiveProps to update this.id if this.props.id changes.

@mikenomitch
Copy link
Contributor Author

mikenomitch commented Nov 5, 2015

@mzabriskie rebased onto new master & made suggested changes

mzabriskie added a commit that referenced this pull request Nov 5, 2015
@mzabriskie
Merge pull request #14 from mikenomitch/master
40ccfe7 
add id and className props for textarea
@mzabriskie mzabriskie merged commit 40ccfe7 into instructure-react:master Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikenomitch @mzabriskie