Allow Chaining of config.setup for Editor Init #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows user plugin configuration without having to hook refs, etc. Still add custom event proxying and initial content, but allow definition of a setup callback that is invoked after wrapper initialization. This allows configuration similar to the official TinyMCE examples (such as http://www.tinymce.com/tryit/3_x/custom_toolbar_button.php)
|
Would love to have this merged. As currently I can't see a way to add custom buttons to the toolbar as per this doc: |
|
Thanks so much for this - solved my issue of not being able to add custom buttons. |
|
+1 |
|
👍 - this would be a great addition. |
|
Any update on merging this? I could really use it too. |
|
@mzabriskie - any possibility we could get some attention on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies config use of the setup callback by chaining it after wrapper tasks. The wrapper still uses this setup routine to proxy events and set initial content. We needed the ability to configure custom buttons with callbacks easily defined within our component.
This allows configuration similar to the official TinyMCE examples.