Skip to content

Fix issues with updating props #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mzabriskie merged 3 commits into from
Jul 7, 2017
Merged

Fix issues with updating props #23

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b5fca8
Fix issues with updating props
JasonTolliver Jan 21, 2016
5244313
Correct the cursor after updating content
JasonTolliver Jan 21, 2016
cc24267
Fix false content updating
JasonTolliver Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix false content updating 
- Because TinyMCE is completely handling its own inner state, you cannot compare nextProps.content with this.props.content.  Instead you must compare with editor.getContent()
  • Loading branch information
@JasonTolliver
JasonTolliver committed Jan 26, 2016
commit cc24267d45c2ba106c036a5f65893bea66fb30ec
5 changes: 3 additions & 2 deletions lib/components/TinyMCE.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ const TinyMCE = React.createClass({
this._init(clone(nextProps.config), nextProps.content);
return;
}
if (!isEqual(this.props.content, nextProps.content)) {
let editor = tinymce.EditorManager.get(this.id);

const editor = tinymce.EditorManager.get(this.id);
if (!isEqual(editor.getContent({format: 'raw'}), nextProps.content)) {
editor.setContent(nextProps.content);

editor.selection.select(editor.getBody(), true);
Expand Down