Skip to content

Change lodash dependency to >=4.0 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mzabriskie merged 1 commit into from
Jul 7, 2017
Merged

Change lodash dependency to >=4.0 #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change lodash dependency to >=4.0 
We have a lot of projects that are consuming this
that are already loading lodash 4.x for other dependencies.
Having this 3.x dependency here was causing us to load a 
separate lodash onto the page just for this.

By bumping this to 4.x+ it will use the same lodash
that everything else on the page is already using
  • Loading branch information
@ryankshaw
ryankshaw committed Jul 6, 2017
commit 438be52d84ad9a6905f275cbd861384c78d6c1c5
4 changes: 2 additions & 2 deletions lib/components/TinyMCE.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import { findDOMNode } from 'react-dom';
import isEqual from 'lodash/lang/isEqual';
import clone from 'lodash/lang/clone';
import isEqual from 'lodash/isEqual';
import clone from 'lodash/clone';
import uuid from '../helpers/uuid';
import ucFirst from '../helpers/ucFirst';

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@
"react-dom": "^15.0.0"
},
"dependencies": {
"lodash": "^3.9.3"
"lodash": ">=4.0.0"
}
}