Skip to content

tried to fix the rerender issue on props change #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vishalsngl wants to merge 1 commit into from
Closed

tried to fix the rerender issue on props change #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tried to fix the rerender issue on props change
  • Loading branch information
vishalsingal committed Sep 11, 2017
commit 8cb7f87e225d2599c065d9c5d8329032bafd4f6a
6 changes: 6 additions & 0 deletions lib/components/TinyMCE.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ const TinyMCE = React.createClass({
// editor.selection.select(editor.getBody(), true);
// editor.selection.collapse(false);
// }

// TODO: This works better for me, not sure if it's the correct solution
const editor = tinymce.EditorManager.get(this.id);
if (editor && !isEqual(editor.getContent(), nextProps.content)) {
editor.setContent(nextProps.content);
}
},

shouldComponentUpdate(nextProps) {
Expand Down