Skip to content

Add license check #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
clangenb merged 2 commits into from
Oct 12, 2022
Merged

Add license check #165

clangenb merged 2 commits into from
Oct 12, 2022

Conversation

@Niederb
Copy link
Contributor

@Niederb Niederb commented Oct 4, 2022 •
edited
Loading

  • Similar to the PR for the pallets repo
  • Note that parachain is already licensed under GPL-3.0
  • Unfortunately the generated license.html does not mention the classpath exception
  • The license check takes quite some time (3 min), but I cannot reproduce this on my machine. There it takes seconds
    • The parachain build already takes a while so it's not that important, but for other repos this can be annoying.

@Niederb Niederb force-pushed the tn/add-license-check branch from a66c8a7 to 3e6926a Compare October 10, 2022 12:22
@Niederb Niederb marked this pull request as ready for review October 10, 2022 12:26
@Niederb Niederb requested review from clangenb and haerdib October 10, 2022 13:16
haerdib
haerdib approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ! Pity that so many polkadot files generate a warning :/

about.toml
"ISC",
"OpenSSL",
"Unicode-DFS-2016",
"Zlib",
Copy link
Contributor

@haerdib haerdib Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So GPL licences allow that many more licences? (comparing to pallets https://github.com/integritee-network/pallets/blob/917dd4f241ea41a50231c1effb060ab38745ad7d/about.hbs)

@Niederb Niederb mentioned this pull request Oct 11, 2022
Merged
clangenb
clangenb approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I trust you on the accepted licences!

.github/workflows/ci.yml
- name: Run license check
# Explicitly use stable because otherwise cargo will trigger a download of
# the nightly version specified in rust-toolchain.toml
run: cargo +stable about generate about.hbs > license.html
Copy link
Contributor

@clangenb clangenb Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch!

@clangenb clangenb merged commit 53ba430 into master Oct 12, 2022
@clangenb clangenb deleted the tn/add-license-check branch December 9, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clangenb clangenb clangenb approved these changes

@haerdib haerdib haerdib approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Niederb @clangenb @haerdib