Cl fixme todos #138
Merged
Cl fixme todos #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 27, 2020 09:08
…instead of Vec<u8>
…get_signing_key as successful fetch is verified in all integration tests and we have no means of verifying here that a "correct" key was fetched. Only if the call was successful.
brenzi
pushed a commit
to encointer/encointer-worker
that referenced
this pull request
Sep 8, 2020
* [stf] make Alice root, and check root in TrustedCall::set_balance call * [tests/commons] annotate that alice is root * [enclave/attestation] remove weird todo * [stf] fix test compilation * [worker/enclave_api] enclave_shielding_key now returns Rsa3072PubKey instead of Vec<u8> * [worker/tests/ecalls] remove todos for testing the get_shielding_key/get_signing_key as successful fetch is verified in all integration tests and we have no means of verifying here that a "correct" key was fetched. Only if the call was successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[STF]
TrustedCall::set_balanceif the signer is root. Alice has been added as root account.[Worker]
Closes #23 , the remaining points have been made to separate issues.