fast-sync targetA/B #1573
Merged
fast-sync targetA/B #1573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenzi
commented
Jan 15, 2024
Comment on lines
+154
to
+157
| warn!("Bad signature on message from {:?}", &signed.id); | ||
| // return Err(ClientError::BadJustification( | ||
| // "invalid signature for precommit in grandpa justification".to_string(), | ||
| // )) |
Collaborator
Author
brenzi
added
A0-core
brenzi
commented
Jan 15, 2024
enclave-runtime/src/lib.rs
Outdated
Comment on lines
485
to
488
| // until fixed properly, we deactivate it altogether in the scope of #1547 | ||
| //if let Err(e) = validate_events(&events_proofs_to_sync, &blocks_to_sync_merkle_roots) { | ||
| // return e.into() | ||
| //} |
Collaborator
Author
There was a problem hiding this comment.
as this causes ParentChainValidation(WrongValue) we skip this for now. needs fixing in #1518 anyway
brenzi
commented
Jan 16, 2024
Comment on lines
+128
to
+169
| Ok(unseal(self.db_path()) | ||
| .or_else(|e| { | ||
| warn!( | ||
| "can't unseal db at {:?}. error {:?}. trying backup at {:?}", | ||
| self.db_path(), | ||
| e, | ||
| self.backup_path() | ||
| ); | ||
| // create a copy because we will overwrite the db in the next step | ||
| fs::copy(self.db_path(), self.db_path().with_extension("cantunseal")).and_then( | ||
| |_| { | ||
| fs::copy(self.backup_path(), self.db_path()).and_then(|_| { | ||
| unseal(self.db_path()).map_err(|e| { | ||
| warn!("{:?}", e); | ||
| e | ||
| }) | ||
| }) | ||
| }, | ||
| ) | ||
| }) | ||
| .map(|b| Decode::decode(&mut b.as_slice()))??) | ||
| } | ||
|
|
||
| // checks if either the db or its backup can be opened in opaque mode (no unseal) | ||
| fn exists(&self) -> bool { | ||
| SgxFile::open(self.db_path()).is_ok() | ||
| debug!("check if db exists at {:?}", self.db_path()); | ||
| fs::File::open(self.db_path()) | ||
| .or_else(|e| { | ||
| warn!( | ||
| "can't open db at {:?}. error: {:?}. trying restore backup at {:?}", | ||
| self.db_path(), | ||
| e, | ||
| self.backup_path() | ||
| ); | ||
| fs::copy(self.backup_path(), self.db_path()) | ||
| .and_then(|_| fs::File::open(self.db_path())) | ||
| .map_err(|e| { | ||
| warn!("{:?}", e); | ||
| e | ||
| }) | ||
| }) | ||
| .is_ok() |
Collaborator
Author
There was a problem hiding this comment.
we finally automate backup restore for sealed db's
while this would merit unit testing, what I manually tested is:
- delete
db.binand the backup will be restored if available - corrupt
db.binusingprintf "\x42" | cat - db.bin > db.bin.corruptand the backup will be restored if available
untested: what if unseal works, but decode doesn't (is this plausible at all? -> yes, if the new enclave changed types. but then the backup is worthless too)
brenzi
commented
Jan 16, 2024
clangenb
reviewed
Jan 17, 2024
Contributor
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
LGTM! I can see that you tried to be very functional. ;)
…de ETA for syncing parentchains
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1570
testing rococo sync
allow plenty of time to fetch the first 1000 blocks.
I was able to import the first chunk of 1000 blocks with this within 10min
testing full story locally