Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
160bb77
Updating submodules
Feb 16, 2023
ba8d6b0
Updating submodules
Feb 16, 2023
ba9dd68
Change some of the stats to rate
haowu14 Feb 17, 2023
ad8bfd6
Updating submodules
Feb 17, 2023
bdad762
Updating submodules
Feb 18, 2023
b42327a
Updating submodules
Feb 19, 2023
0d49b53
Updating submodules
Feb 20, 2023
bb2d1c6
Updating submodules
Feb 21, 2023
c167a83
Updating submodules
Feb 21, 2023
32ed439
Return replacedPtr from InsertOrReplace API
Feb 21, 2023
dd0af61
Updating submodules
Feb 21, 2023
cce19ea
Updating submodules
Feb 22, 2023
6357906
Pin fmt version at 8.0.1 (#196)
wonglkd Feb 24, 2023
a925737
KVReplayGenerator: parse GET_LEASE and SET_LEASE operations
Feb 25, 2023
f7e13a4
Update @braintree/sanitize-url version
Feb 27, 2023
70ff91f
Add missing numa deps for fedora, rocky, arch (#197)
wonglkd Feb 27, 2023
6ad7a31
fbcode/cachelib/allocator/datastruct/serialize
Feb 27, 2023
df5b9f6
Run Github Actions on pull requests (#198)
wonglkd Feb 28, 2023
e8151ad
Add a custom deleter class to access the Item Handle
Feb 28, 2023
9827818
fix flaky tests in NvmCacheTests
Feb 28, 2023
9447a8a
Added PM9A3 support for Cachebench Write Bytes Calculations
Mar 1, 2023
293118b
Fix XDCHECK regression in lambda for gcc-8.x (#201)
wonglkd Mar 1, 2023
f853a42
Get or update object TTL via object shared_ptr
Mar 1, 2023
c120a53
Remove isWriteHandle() API
Mar 2, 2023
7785d24
Edit Cachebench_FB_HW_eval.md using inpage editor
Mar 2, 2023
185bbe6
Fix Debian GitHub build & zstd CMake error (#200)
wonglkd Mar 2, 2023
968533f
fix broken installation page link
Mar 3, 2023
496ed37
fix another broken installation page link in index.js
Mar 3, 2023
67d2d8b
temporarily disable PackIt (#205)
michel-slm Mar 5, 2023
115732a
Edit Overview_A_random_walk_down_the_Cache_Library.md using inpage ed…
Mar 6, 2023
17bdc18
fbcode/cachelib/experimental/objcache2/persistence
Mar 7, 2023
e679b72
README.md: added build status badges to main README.md
Mar 7, 2023
43a7ce3
Fix Bug in ItemValue handling in CacheBench
Mar 8, 2023
872d61a
fbcode/cachelib/benchmarks
Mar 9, 2023
ffa5470
fbcode/cachelib/allocator/datastruct/tests
Mar 9, 2023
1031b13
fbcode/cachelib/experimental/objcache2/tests
Mar 9, 2023
d92910b
fbcode/cachelib/experimental/objcache/tests
Mar 9, 2023
1e05a16
fbcode/cachelib/navy/serialization
Mar 9, 2023
0bc9f66
Introduce 'markedForEviction' state for the Item. (#183)
igchor Mar 9, 2023
0bdb935
fbcode/cachelib/allocator/serialize
Mar 9, 2023
99a05d3
fbcode/cachelib/experimental/objcache
Mar 9, 2023
d1ff29c
fbcode/cachelib/
Mar 10, 2023
3a8d8b4
Add extra notes for object-cache find APIs
Mar 13, 2023
47e5632
Add memory usage statistics for allocation classes
igchor Jul 6, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pin fmt version at 8.0.1 (facebook#196)
Summary:
Change build script to pin fmt version to same as folly's to minimize future breaks.

Pull Request resolved: facebook#196

Test Plan:
Built successfully on a fresh clone of CacheLib. (Also had to change `external_git_branch=dev` for zstd to deal with the cmake/zstd issue in facebook#194, but that should resolve when gets merged into release)

**Context:** OSS build broke between 3-5 Jan 2023, likely due to changes in folly. While switching to v9.1.0 or 9.0.0 fixes the issue at hand, it seems sensible to match folly, which specifies fmt v8.0.1: https://github.com/facebook/folly/blob/main/build/fbcode_builder/manifests/fmt

> facebook#62 agordon: For the other packages, you'll notice we do use a specific git tag or branch… I notice `fmt` is an exception - not pinned to a specific git tag or revision - likely an omission that can be fixed.

Related CacheLib issues: facebook#186, facebook#189, facebook#107, facebook#97, facebook#62
Possibly related CacheLib commit: 67cc11a

Last working (Jan 3): https://github.com/facebook/CacheLib/actions/runs/3826992478
First failed (Jan 5): https://github.com/facebook/CacheLib/actions/runs/3844002307/jobs/6546742348
Error: `error: static assertion failed: Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt`

Reviewed By: therealgymmy

Differential Revision: D43517927

Pulled By: jiayuebao

fbshipit-source-id: 2d28791f7804d862b646263b96b10b835f843d8c
  • Loading branch information
wonglkd authored and facebook-github-bot committed Feb 24, 2023
commit 6357906c331954f34eccc5b870a7984da79f27f4
1 change: 1 addition & 0 deletions contrib/build-package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ case "$1" in
REPODIR=cachelib/external/$NAME
SRCDIR=$REPODIR
external_git_clone=yes
external_git_tag="8.0.1"
cmake_custom_params="-DBUILD_SHARED_LIBS=ON"
if test "$build_tests" = "yes" ; then
cmake_custom_params="$cmake_custom_params -DFMT_TEST=YES"
Expand Down