Skip to content

[upstream] transparent Item movement #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[upstream] transparent Item movement #92

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d73cfe
Transparent Item movements
vinser52 Jul 28, 2023
c572aa2
test case for acquire parent
byrnedj Nov 8, 2023
fb8e23c
use findInternal to sync on ac lock
byrnedj Nov 8, 2023
fe21ef6
Merge pull request #5 from byrnedj/fix_acquire_rebased
vinser52 Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use findInternal to sync on ac lock
  • Loading branch information
@byrnedj
byrnedj committed Nov 13, 2023
commit fb8e23c996fb1b61818da4022723535f6dae6486
3 changes: 2 additions & 1 deletion cachelib/allocator/CacheAllocator-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2639,6 +2639,7 @@ bool CacheAllocator<CacheTrait>::moveForSlabRelease(
const auto allocInfo = allocator_->getAllocInfo(oldItem.getMemory());
if (chainedItem) {
newItemHdl.reset();
auto parentKey = parentItem->getKey();
auto ref = parentItem->unmarkMoving();
if (UNLIKELY(ref == 0)) {
wakeUpWaiters(*parentItem, {});
Expand All @@ -2648,7 +2649,7 @@ bool CacheAllocator<CacheTrait>::moveForSlabRelease(
return true;
} else {
XDCHECK_NE(ref, 0);
auto parentHdl = acquire(parentItem);
auto parentHdl = findInternal(parentKey);
if (parentHdl) {
wakeUpWaiters(*parentItem, std::move(parentHdl));
}
Expand Down