Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix sql injection for grpc
Signed-off-by: Kaihui-intel <[email protected]>
  • Loading branch information
Kaihui-intel committed Jun 20, 2024
commit ee30b87b00a2ab2c2fa0835e8fa16a80993515cf
31 changes: 19 additions & 12 deletions neural_solution/frontend/utility.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,30 +140,37 @@ def submit_task_to_db(task, task_submitter, db_path):
status = "failed"
task_id = "-1"
result = {"status": status, "task_id": task_id, "msg": msg}
if not is_valid_task(task.__dict__):
return result
if os.path.isfile(db_path):
conn = sqlite3.connect(db_path)
cursor = conn.cursor()
task_id = str(uuid.uuid4()).replace("-", "")
sql = (
r"insert into task(id, script_url, optimized, arguments, approach, requirements, workers, status)"
+ r" values ('{}', '{}', {}, '{}', '{}', '{}', {}, 'pending')".format(
task_id,
task.script_url,
task.optimized,
list_to_string(task.arguments),
task.approach,
list_to_string(task.requirements),
task.workers,
)
"INSERT INTO task "
"(id, script_url, optimized, arguments, approach, requirements, workers, status) "
"VALUES (?, ?, ?, ?, ?, ?, ?, 'pending')"
)
cursor.execute(sql)

task_params = (
task_id,
task.script_url,
task.optimized,
list_to_string(task.arguments),
task.approach,
list_to_string(task.requirements),
task.workers,
)

conn.execute(sql, task_params)
conn.commit()
try:
task_submitter.submit_task(task_id)
except ConnectionRefusedError:
msg = "Task Submitted fail! Make sure neural solution runner is running!"
except Exception as e:
msg = "Task Submitted fail! {}".format(e)
msg = "Task Submitted fail!"
print(f"Task Submitted fail! {e}")
conn.close()
status = "successfully"
msg = "Task submitted successfully"
Expand Down