Skip to content

chore: cleanup unused and deprecated code #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gregdhill merged 1 commit into from
Aug 4, 2023
Merged

chore: cleanup unused and deprecated code #1152

gregdhill merged 1 commit into from
Aug 4, 2023

Conversation

@gregdhill
Copy link
Member

@gregdhill gregdhill commented Jul 31, 2023

Making this PR to run the benchmarks for the release, no functional changes are included.

gregdhill
gregdhill commented Jul 31, 2023
View reviewed changes
parachain/src/service.rs
extra_pages: h as _,
});

let executor = NativeElseWasmExecutor::<Executor>::new_with_wasm_executor(
Copy link
Member Author

@gregdhill gregdhill Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the native executor is soon going to be deprecated, I saw some other projects such as Acala and Bifrost only use the WASM executor now so we may also consider following suit.

Copy link
Member

@sander2 sander2 Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a source on this? The native executor is a lot more efficient so isn't it preferable?

Copy link
Member Author

@gregdhill gregdhill Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I saw someone commented on the PR which deprecates the new constructor here but then I found this issue with a more detailed explanation. Statemint has also already switched to wasm runtime only, see this PR.

@gregdhill
Copy link
Member Author

gregdhill commented Jul 31, 2023

/run_benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Request: /run_benchmarks
Command: bash ./scripts/benchmark.sh -r * -p *

Running...

@gregdhill
Copy link
Member Author

gregdhill commented Jul 31, 2023

/run_benchmarks interlay

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Request: /run_benchmarks interlay
Command: bash ./scripts/benchmark.sh -r * -p *

Running...

@ns212
Copy link
Contributor

ns212 commented Aug 1, 2023

/run_benchmarks interlay-dev

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Request: /run_benchmarks interlay-dev
Command: bash ./scripts/benchmark.sh -r dev -p *

Running...

@gregdhill
Copy link
Member Author

gregdhill commented Aug 3, 2023

/run_benchmarks interlay-dev

1 similar comment
@gregdhill
Copy link
Member Author

gregdhill commented Aug 3, 2023

/run_benchmarks interlay-dev

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Request: /run_benchmarks interlay-dev
Command: bash ./scripts/benchmark.sh -r interlay-dev -p *

Running...

@gregdhill
Copy link
Member Author

gregdhill commented Aug 3, 2023

/run_benchmarks interlay-dev

1 similar comment
@gregdhill
Copy link
Member Author

gregdhill commented Aug 3, 2023

/run_benchmarks interlay-dev

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Request: /run_benchmarks interlay-dev
Command: bash ./scripts/benchmark.sh -r interlay-dev -p ''*''

Running...

@gregdhill
Copy link
Member Author

gregdhill commented Aug 3, 2023

/run_benchmarks interlay-dev

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Request: /run_benchmarks interlay-dev
Command: bash ./scripts/benchmark.sh -r interlay-dev -p

Running...

@gregdhill
Copy link
Member Author

gregdhill commented Aug 3, 2023

/run_benchmarks interlay-dev

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Request: /run_benchmarks interlay-dev
Command: bash ./scripts/benchmark.sh -r interlay-dev -p

Running...

@gregdhill gregdhill force-pushed the chore/cleanup-unused branch from 6e956d2 to 7403064 Compare August 3, 2023 16:48
@gregdhill
Copy link
Member Author

gregdhill commented Aug 3, 2023

/run_benchmarks interlay-dev

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Request: /run_benchmarks interlay-dev
Command: bash ./scripts/benchmark.sh -r interlay-dev -p

Running...

@gregdhill gregdhill merged commit 4c7c13c into interlay:master Aug 4, 2023
@gregdhill gregdhill deleted the chore/cleanup-unused branch August 4, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sander2 sander2 sander2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gregdhill @ns212 @sander2