chore: upgrade to polkadot-v0.9.31 #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <[email protected]>
Signed-off-by: Gregory Hill <[email protected]>
Signed-off-by: Gregory Hill <[email protected]>
gregdhill
force-pushed
the
chore/polkadot-v0.9.31
branch
from
53155df to
8e85415
Compare
Signed-off-by: Gregory Hill <[email protected]>
sander2
reviewed
Nov 14, 2022
Member
sander2
left a comment
sander2
left a comment
There was a problem hiding this comment.
paritytech/substrate#11649 state this:
Runtime storage migrations must be run for:
- Preimage pallet
- Scheduler pallet
- Democracy pallet
I guess we don't need the democracy one since we use a fork, but don't we have to run the preimage one?
Also, we need to remember to run try-runtime on mainnets for these
Signed-off-by: Gregory Hill <[email protected]>
Signed-off-by: Gregory Hill <[email protected]>
sander2
previously approved these changes
Nov 14, 2022
Signed-off-by: Gregory Hill <[email protected]>
Signed-off-by: Gregory Hill <[email protected]>
Signed-off-by: Gregory Hill <[email protected]>
sander2
reviewed
Nov 15, 2022
| /// We allow for 2 seconds of compute with a 12 second average block time. | ||
| const MAXIMUM_BLOCK_WEIGHT: Weight = WEIGHT_PER_SECOND.saturating_mul(2 as u64); | ||
| pub const MAXIMUM_BLOCK_WEIGHT: Weight = WEIGHT_PER_SECOND | ||
| .saturating_div(2) |
Member
There was a problem hiding this comment.
We only allow 0.5 sec of block production?
Member
Author
There was a problem hiding this comment.
Yea that comment is wrong, see the configuration for statemine / statemint here: https://github.com/paritytech/cumulus/blob/3095325ac440cd3f30efb4acc0e6d7b84a1609ff/parachains/common/src/lib.rs#L94
sander2
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Succeeds #765
Succeeds #761
Changes
paritytech/substrate@polkadot-v0.9.30...polkadot-v0.9.31
Callparitytech/substrate#11649Notes
Upstream democracy removed
enact_proposal, we should do the same but that requires some additional changes to the preimage setup. I've opted to hard-code the weight of this call to1000instead of the max to limit the number of breaking changes and allow the scheduler to actually service proposal tasks.Runs all migrations as listed here: paritytech/polkadot#5729