Skip to content

refactor: bound entries in collator-selection #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregdhill merged 2 commits into from
Jan 24, 2023
Merged

refactor: bound entries in collator-selection #879

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
733497a
refactor: bound entries in collator-selection
gregdhill Jan 23, 2023
c6fc462
fix: only register MaxCandidates-1 candidates initially
gregdhill Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: only register MaxCandidates-1 candidates initially 
Signed-off-by: Gregory Hill <[email protected]>
  • Loading branch information
@gregdhill
gregdhill committed Jan 24, 2023
commit c6fc4628dbe754130c4e6a168fb0e5a64858ea1c
2 changes: 1 addition & 1 deletion crates/collator-selection/src/benchmarking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ benchmarks! {
// worse case is when we have all the max-candidate slots filled except one, and we fill that
// one.
register_as_candidate {
let c in 1 .. T::MaxCandidates::get();
let c in 1 .. T::MaxCandidates::get() - 1;

<CandidacyBond<T>>::put(T::StakingCurrency::minimum_balance());
<DesiredCandidates<T>>::put(c + 1);
Expand Down