fix(unpluing-vue-i18n): Support for transform.handler in vite:json plugin
#484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the handling of the Vite JSON plugin to support the new transform.handler hook introduced in Vite 6.3, in preparation for Vite 7.
- Introduces helper functions getVitePluginTransform and overrideVitePluginTransform to manage different transform hook types.
- Updates the resource plugin to use the new transform override mechanism for the vite:json plugin.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/unplugin-vue-i18n/src/utils/plugin.ts | Adds utility functions to extract and override the Vite plugin transform hook based on the new handler pattern. |
| packages/unplugin-vue-i18n/src/core/resource.ts | Adapts the JSON transform handling in the resource plugin to leverage the new transform override utilities. |
Comment on lines
+30
to
+34
| // TODO: `override` type, we need more strict type | ||
| export function overrideVitePluginTransform( | ||
| plugin: RollupPlugin, | ||
| override: Function, | ||
| to: 'handler' | 'transform' |
There was a problem hiding this comment.
[nitpick] Refine the type for the override parameter to improve type safety and prevent potential runtime issues.
Suggested change
| // TODO: `override` type, we need more strict type | |
| export function overrideVitePluginTransform( | |
| plugin: RollupPlugin, | |
| override: Function, | |
| to: 'handler' | 'transform' | |
| // TODO: Refined `override` type for stricter type safety | |
| export function overrideVitePluginTransform< | |
| T extends 'handler' | 'transform' | |
| >( | |
| plugin: RollupPlugin, | |
| override: T extends 'handler' | |
| ? typeof plugin.transform extends { handler: infer H } | |
| ? H | |
| : never | |
| : typeof plugin.transform, | |
| to: T |
| } | ||
|
|
||
| // override `vite:json` plugin transform function | ||
| overrideVitePluginTransform(jsonPlugin, overrideViteJsonPlugin, transformWay!) |
There was a problem hiding this comment.
Instead of using a non-null assertion on transformWay, consider validating its presence before overriding to ensure more robust error handling.
Suggested change
| overrideVitePluginTransform(jsonPlugin, overrideViteJsonPlugin, transformWay!) | |
| overrideVitePluginTransform(jsonPlugin, overrideViteJsonPlugin, transformWay) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In vite 6.3, the handling of plugin hooks has been changed from transform to transform.handler internally.
Currently, vite is minimizing the impact on end users through a patch, but in vite 7, the patch for transform will be removed.
Linked Issues
Additional context
Rollup used internally in Vite will be replaced by Rolldown in the future. Rolldown plans to provide JSON transform plugin natively, but the current workaround that hijacks the unplugin-vue-i18n Vite JSON plugin cannot be used.
Regarding this issue, the Rolldown team and Vite team are currently discussing a workaround mechanism at the following URL.
vitejs/rolldown-vite#120