Skip to content

Chore: Add lerna as peer dependency #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackw wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

Chore: Add lerna as peer dependency #2441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore(npm): add lerna as peer dependency to the packages that use it
  • Loading branch information
@jackw
jackw committed Feb 29, 2024
commit 7f3c7736a89fbe12d7a7f04fbbd33eb97ca84f6e
6 changes: 4 additions & 2 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@
"url-join": "^4.0.0"
},
"peerDependencies": {
"typescript": ">=2.7"
"typescript": ">=2.7",
"lerna": "^7.1.4"
Copy link
Collaborator

@hipstersmoothie hipstersmoothie Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm it probably doesn't make sense for core to depend on lerna...

Copy link
Collaborator

@hipstersmoothie hipstersmoothie Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only the all contributors plugin depends on that.

I think we should either:

  1. move that function into a dep
  2. just copy the function into the 2 places we use it (npm and all-contributors)

I think 2 is better. then we can say lerna is an optionalPeerDep of the all-contributors plugin

},
"peerDependenciesMeta": {
"@types/node": {
Expand All @@ -98,6 +99,7 @@
"@types/signale": "^1.2.1",
"@types/tinycolor2": "^1.4.1",
"@types/url-join": "^4.0.0",
"graphql": "^15.0.0"
"graphql": "^15.0.0",
"lerna": "^7.1.4"
}
}
6 changes: 5 additions & 1 deletion plugins/npm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@
"@types/env-ci": "^3.1.0",
"@types/semver": "^7.1.0",
"@types/url-join": "^4.0.0",
"@types/user-home": "^2.0.0"
"@types/user-home": "^2.0.0",
"lerna": "^7.1.4"
},
"peerDependencies": {
"lerna": "^7.1.4"
}
}