test(OAuthClient) Add Additional unit tests for OAuthClient (#47) (#49)

- Added tests for OAuthClient to bring test coverage higher
- re-worked logic in OAuthClient.createError to be more consistent

Author: edgarsherman

package.json

@@ -36,10 +36,10 @@
       "test"
     ],
     "check-coverage": true,
-    "lines": 75,
-    "statements": 75,
-    "functions": 71,
-    "branches": 56,
+    "lines": 85,
+    "statements": 85,
+    "functions": 80,
+    "branches": 75,
     "reporter": [
       "lcov",
       "text",
@@ -81,6 +81,7 @@
   "devDependencies": {
     "body-parser": "^1.15.2",
     "chai": "^4.1.2",
+    "chai-as-promised": "^7.1.1",
     "chance": "^1.0.13",
     "cors": "^2.8.1",
     "coveralls": "^3.0.6",

src/OAuthClient.js

@@ -583,19 +583,32 @@ OAuthClient.prototype.loadResponseFromJWKsURI = function loadResponseFromJWKsURI
  */
 OAuthClient.prototype.createError = function createError(e, authResponse) {
   if (!authResponse || authResponse.body === '') {
-    e.error = e.originalMessage || '';
+    e.error = (authResponse && authResponse.response.statusText) || e.message || '';
     e.authResponse = authResponse || '';
-    e.intuit_tid = authResponse.headers().intuit_tid || '';
-    e.originalMessage = authResponse.response.statusText || '';
-    e.error = authResponse.response.statusText || '';
-    e.error_description = authResponse.response.statusText || '';
+    e.intuit_tid = (authResponse && authResponse.headers().intuit_tid) || '';
+    e.originalMessage = e.message || '';
+    e.error_description = (authResponse && authResponse.response.statusText) || '';
     return e;
   }
 
-  e.authResponse = authResponse || null;
+  e.authResponse = authResponse;
   e.originalMessage = e.message;
-  e.error = ('error' in authResponse.getJson() ? authResponse.getJson().error : '');
-  e.error_description = ('error_description' in authResponse.getJson() ? authResponse.getJson().error_description : '');
+
+  e.error = '';
+  if ('error' in authResponse.getJson()) {
+    e.error = authResponse.getJson().error;
+  } else if (authResponse.response.statusText) {
+    e.error = authResponse.response.statusText;
+  } else if (e.message) {
+    e.error = e.message;
+  }
+
+  e.error_description = '';
+  if ('error_description' in authResponse.getJson()) {
+    e.error_description = authResponse.getJson().error_description;
+  } else if (authResponse.response.statusText) {
+    e.error_description = authResponse.response.statusText;
+  }
   e.intuit_tid = authResponse.headers().intuit_tid;
 
   return e;