test(AuthResponse) Add Additional unit tests for AuthResponse #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests for AuthResponse to bring it to 100% - modified nyc config to exclude test directory - incorrectly affecting the coverage numbers - modified nyc config to report per-file coverage at the end of a test run - reduced coverage threshold so we still meet standards (Note: I'll continue to add tests for OAuthClient.js to bring it up)
Collaborator
Sounds good ! |
edgarsherman
pushed a commit
to edgarsherman/oauth-jsclient
that referenced
this pull request
Oct 16, 2019
- Added tests for OAuthClient to bring test coverage higher - re-worked logic in OAuthClient.createError to be more consistent
abisalehalliprasan
pushed a commit
that referenced
this pull request
Oct 16, 2019
Collaborator
|
🚀 PR was released in v2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the coverage numbers
continue to add tests for OAuthClient.js to bring it up)
Reference issue #39, but only partially bring code coverage up. I'll continue to add more in a different PR.