Skip to content

Fix/eslint formatting #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abisalehalliprasan merged 4 commits into from
Oct 5, 2019
Merged

Fix/eslint formatting #38

abisalehalliprasan merged 4 commits into from
Oct 5, 2019

Conversation

@mcrosby114
Copy link
Contributor

@mcrosby114 mcrosby114 commented Oct 4, 2019

Addresses the all the eslint errors except the "no-undef" from #32.

@mcrosby114
Copy link
Contributor Author

mcrosby114 commented Oct 4, 2019 •
edited
Loading

@abisalehalliprasan can we upgrade the version of node to something greater than 6, like version 8? Seeing there's an issue with the JS engine not recognizing Object.entries() (https://travis-ci.org/intuit/oauth-jsclient/jobs/593613545#L292).

This shows how it's incompatible with the current version of node: https://node.green/#ES2017-features-Object-static-methods-Object-entries

@abisalehalliprasan
Copy link
Collaborator

abisalehalliprasan commented Oct 5, 2019

@abisalehalliprasan can we upgrade the version of node to something greater than 6, like version 8? Seeing there's an issue with the JS engine not recognizing Object.entries() (https://travis-ci.org/intuit/oauth-jsclient/jobs/593613545#L292).

This shows how it's incompatible with the current version of node: https://node.green/#ES2017-features-Object-static-methods-Object-entries

Yeah, I think it should be fine. I can bump a version up and release, following the sem version.

Looks Good @mcrosby114 👍 🙌

@abisalehalliprasan abisalehalliprasan merged commit ad56e5f into intuit:develop Oct 5, 2019
@abisalehalliprasan
Copy link
Collaborator

abisalehalliprasan commented Oct 18, 2019

🚀 PR was released in v2.0.0 hacktoberfest

@mcrosby114
Copy link
Contributor Author

mcrosby114 commented Oct 18, 2019

#38 (comment) 🙌

@snyk-bot snyk-bot mentioned this pull request May 25, 2021
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Oct 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mcrosby114 mcrosby114

Labels

hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcrosby114 @abisalehalliprasan