Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
afbcc03
Squashing Commits to single commit
abisalehalliprasan Sep 30, 2019
bbd13f4
Merge branch 'master' into develop
abisalehalliprasan Sep 30, 2019
7702bba
.npmignore changes fixed
abisalehalliprasan Sep 30, 2019
5050818
.npmignore changes fixed
abisalehalliprasan Sep 30, 2019
f4379bb
Implementing Github Actions : develop branch
abisalehalliprasan Oct 3, 2019
ad56e5f
Fix/eslint formatting (#38)
mcrosby114 Oct 5, 2019
109a0d3
Added require statement for global mocha functions to fix linting err…
hallzac2 Oct 7, 2019
03249de
Fixed README.md missing/broken links (#42)
MDBoticano Oct 9, 2019
90cfde4
added test for 'clearTest' function (#44)
Rockleeland Oct 10, 2019
15072f4
Adding Develop Code Coverage Badge
abisalehalliprasan Oct 10, 2019
3a8d6af
Merge branch 'develop' of https://github.com/intuit/oauth-jsclient in…
abisalehalliprasan Oct 10, 2019
28f52be
test(AuthResponse) Add Additional unit tests for AuthResponse (#47)
edgarsherman Oct 10, 2019
4cdaee8
Upgrade ngrok to 3.2.5 in the sample app. (#45)
petmat Oct 14, 2019
1b598c4
test(OAuthClient) Add Additional unit tests for OAuthClient (#47) (#49)
edgarsherman Oct 16, 2019
74fdbfa
Provide support for other HTTP methods, headers, and body content (#48)
brycejech Oct 16, 2019
81c8cd7
Fix eslint issues develop (#51)
nehapatwardhan6490 Oct 17, 2019
640dad9
Release Candidate 2.0.0
abisalehalliprasan Oct 17, 2019
ec3f14a
Release Candidate 2.0.0
abisalehalliprasan Oct 18, 2019
3685c8f
Release Candidate 2.0.0
abisalehalliprasan Oct 18, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Upgrade ngrok to 3.2.5 in the sample app. (#45)
This fixes issue 41.
Also switched from callback to promises in the NGROK connect call.
  • Loading branch information
petmat authored and abisalehalliprasan committed Oct 14, 2019
commit 4cdaee897183ada6278a51f0693176221b8886fd
26 changes: 12 additions & 14 deletions sample/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,19 +163,17 @@ if(!ngrok){
if (ngrok) {

console.log("NGROK Enabled");
ngrok.connect({addr: process.env.PORT || 8000}, (err, url) => {
if (err) {
process.exit(1);
}
else {
redirectUri = url + '/callback';
console.log(`💳 Step 1 : Paste this URL in your browser : ${url}`);
console.log('💳 Step 2 : Copy and Paste the clientId and clientSecret from : https://developer.intuit.com')
console.log(`💳 Step 3 : Copy Paste this callback URL into redirectURI : ${redirectUri}`);
console.log(`💻 Step 4 : Make Sure this redirect URI is also listed under the Redirect URIs on your app in : https://developer.intuit.com`);

}
}
);
ngrok.connect({addr: process.env.PORT || 8000})
.then(url => {
redirectUri = url + '/callback';
console.log(`💳 Step 1 : Paste this URL in your browser : ${url}`);
console.log('💳 Step 2 : Copy and Paste the clientId and clientSecret from : https://developer.intuit.com')
console.log(`💳 Step 3 : Copy Paste this callback URL into redirectURI : ${redirectUri}`);
console.log(`💻 Step 4 : Make Sure this redirect URI is also listed under the Redirect URIs on your app in : https://developer.intuit.com`);

})
.catch(() => {
process.exit(1);
});
}

2 changes: 1 addition & 1 deletion sample/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"path": "^0.12.7",
"ejs": "^2.5.2",
"dotenv": "^5.0.1",
"ngrok": "^2.2.9",
"ngrok": "^3.2.5",
"intuit-oauth": "1.3.0"
}
}