feat(nodes): better ui_type deprecations #8586
Merged
+193
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Sep 19, 2025
- Move migration of model-specific ui_types into BaseInvocation. This gives us access to the node and field names, so the warnings are more useful to the end user. - Ensure we serialize the fields' json_schema_extra with enum values. This wasn't a problem until now, when it interferes with migrating ui_type cleanly. It's a transparent change. - Improve warnings when validating fields (which includes the ui_type migration logic)
psychedelicious
force-pushed
the
psyche/feat/nodes/better-uitype-deprecations
branch
from
d62855f to
8d26230
Compare
psychedelicious
deleted the
psyche/feat/nodes/better-uitype-deprecations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves how ui_type deprecations are handled.
Related Issues / Discussions
Improvement on changes in #8577
QA Instructions
@JPPhoto I expect this change to give you 1) many more warnings and 2) better warnings
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)