remove old eventlistener #1134
Merged
remove old eventlistener #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was removed in dotnet/fsharp#13835
TheAngryByrd
force-pushed
the
remove-old-eventlistener
branch
from
42a3f7f to
2df1b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 42a3f7f
This pull request simplifies the logging system by removing the
Debugmodule and the compiler event listener. This reduces the code complexity and improves the performance of theFsAutoCompleteproject. The changes affect the filesDebug.fsandParser.fs.🤖 Generated by Copilot at 42a3f7f
🗑️⚡🛠️
WHY
The source was removed in dotnet/fsharp#13835 in favor of OpenTelemetry Activities.
Also this causes a ton of garbage logs when connecting with
dotnet-countersHOW
🤖 Generated by Copilot at 42a3f7f
Debugmodule andLogCompilerFunctionIdtype, which logged compiler events (link, link)