Filestore: add Provider option to provide filestore blocks. #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses ipfs/kubo#10983 |
A Filestore is a Blockstore wrapper. When I moved providing resposibilities to Blockstore/Pinner/MFS... I forgot the Filestore. In Particular, the Filestore writes all blocks to the Blockstore except those of FilestoreNode type, which are serialized and written to the datastore directly via the Filemanager. The data serialized is not the block itself, but a pointer to a filesystem object and an offset. So FilestoreNodes escaped providing even when the blockstore is configured to provide... Not anymore.
hsanjuan
force-pushed
the
feat/providing-filestore
branch
from
8d6d2d8 to
5825d7a
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1042 +/- ##
==========================================
+ Coverage 60.58% 60.69% +0.11%
==========================================
Files 263 268 +5
Lines 33502 33628 +126
==========================================
+ Hits 20296 20411 +115
- Misses 11531 11539 +8
- Partials 1675 1678 +3
... and 22 files with indirect coverage changes 🚀 New features to boost your workflow:
|
hsanjuan
commented
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Filestore is a Blockstore wrapper. When I moved providing resposibilities to Blockstore/Pinner/MFS... I forgot the Filestore. In Particular, the Filestore writes all blocks to the Blockstore except those of FilestoreNode type, which are serialized and written to the datastore directly via the Filemanager. The data serialized is not the block itself, but a pointer to a filesystem object and an offset.
So FilestoreNodes escaped providing even when the blockstore is configured to provide... Not anymore.