Skip to content

Conversation

@gammazero
Copy link
Contributor

@gammazero gammazero commented Feb 11, 2025

Gogo protobuf is deprecated. Move ipld/unixfs away from it.

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 57.03704% with 58 lines in your changes missing coverage. Please review.

Project coverage is 60.56%. Comparing base (9e4f046) to head (97711dc).

Files with missing lines Patch % Lines
ipld/unixfs/pb/unixfs.pb.go 57.03% 56 Missing and 2 partials ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #840   +/-   ##
=======================================
  Coverage   60.55%   60.56%           
=======================================
  Files         244      244           
  Lines       31136    31177   +41     
=======================================
+ Hits        18855    18882   +27     
- Misses      10604    10618   +14     
  Partials     1677     1677           
Files with missing lines Coverage Δ
ipld/unixfs/unixfs.go 79.93% <ø> (ø)
ipld/unixfs/pb/unixfs.pb.go 54.32% <57.03%> (+6.38%) ⬆️

... and 8 files with indirect coverage changes

@gammazero gammazero marked this pull request as ready for review February 11, 2025 11:28
@gammazero gammazero requested a review from a team as a code owner February 11, 2025 11:28
@gammazero gammazero changed the title Move ipld/unixfs from gogo protobuf move ipld/unixfs from gogo protobuf Feb 11, 2025
@gammazero gammazero marked this pull request as draft February 11, 2025 11:55
@gammazero gammazero marked this pull request as ready for review February 11, 2025 11:56
@gammazero gammazero merged commit af31f60 into main Feb 18, 2025
13 checks passed
@gammazero gammazero deleted the move-unixfs-from-gogo branch February 19, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants