Bitswap: Set DontHaveTimeout/MinTimeout to 25ms #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanjuan
force-pushed
the
bitswap-min-donthave-timeout
branch
from
d9f3be7 to
65054e3
Compare
|
(i will fix the tests) |
As seen in ipfs/go-ds-crdt#285, and mentioned in #865, the don't have timeout for very low latency setups becomes very low (2.5ms) and cannot handle any sort of spike. In a localhost network with two peers, this causes loss of bitswap connectivity altogether, and is unrecoverable without manually reconnecting, or finding the other peer as provider. Why 200ms? Didn't seem to low nor too high.
hsanjuan
force-pushed
the
bitswap-min-donthave-timeout
branch
from
39b92d3 to
2fc8a75
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #959 +/- ##
==========================================
- Coverage 61.61% 61.61% -0.01%
==========================================
Files 254 253 -1
Lines 31396 31374 -22
==========================================
- Hits 19346 19331 -15
+ Misses 10479 10475 -4
+ Partials 1571 1568 -3
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Triage notes:
|
|
Merging per discussion in triage. |
lidel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in ipfs/go-ds-crdt#285, and mentioned in #865, the don't have timeout for very low latency setups becomes very low (2.5ms) and cannot handle any sort of spike.
In a localhost network with two peers, this causes loss of bitswap connectivity altogether, and is unrecoverable without manually reconnecting, or finding the other peer as provider.
Why 200ms? Didn't seem to low nor too high.