files returned from unixfsnode should be traversable to their substrate #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
My quick test looks good with this. |
Merged
|
Thanks a lot, I tried and so far it works like a charm. You made my day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is looking at the fuse issue raised in ipfs/kubo#9044 (comment)
What seems to occur is that the node we get when resolving a file returns a unixfsnode File.
The
ProtoNodeConverteronly works on a direct PBNode so in the case that the response has been ADL'd into a unixfs File, we need to give it the substrate rather than the fileseparately, this logic is brittle / unable to handle the
io.ReadSeeker/ large bytes node efficiency possible with unixfsnode and should get a larger refactor to support that.However, in the mean time, this indicates that these files do comply with the ADL interface and so we can get the underlying substrate for use in fuse rather than the full file ipld object.