This repository was archived by the owner on Feb 12, 2024. It is now read-only.
[WIP] feat: Add rendezvous #1396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pgte
requested review from
dignifiedquire
and removed request for
dignifiedquire
Contributor
|
@mkg20001 @alanshaw Any news on this? We need this for peer-base/peer-base#5 |
Member
|
@pgte in lieu of it being a default discovery module can you pass it as |
Contributor
Author
|
@pgte This would have to be properly integrated into libp2p instead of IPFS, I think. Current blocker is that rendezvous requires swarm, and swarm should depend on rendezvous as a discovery module. (chicken&egg problem). There needs to be a better solution to that than just adding more hacks. |
Member
|
@mkg20001 shall we close this PR for the time being? |
Contributor
Author
|
@alanshaw Yes. I think the whole "X requires swarm but is component for swarm" situation requires a refactor anyways |
ghost
removed
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for libp2p-rendezvous protocol
ToDOs: