This repository was archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Awesome Endeavour: Circuit Relay #830
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9aef6b7
feat: enable circuit relay
dryajov e3957d2
chore: update deps
daviddias 72b6fb6
chore: clean the house a bit
daviddias 492fa16
test: avoid spawning nodes that not used
daviddias c7fd99a
test: clean up bitswap tests
daviddias 1742398
test: move timeouts
daviddias 50b29e4
fix(test): move timeouts to the top
dryajov aa98ec0
feat: run interop tests with new aegir
dryajov c5c88aa
onto interop tests
daviddias 18f5a9a
chore
daviddias 983bfd9
abrvs
daviddias 61e1266
chore: more clean up
daviddias 19d8555
interop exchange files is all good
daviddias 36afc59
update deps
daviddias bad8232
only missing circuit relay interop tests
daviddias 05e19a0
skip circuit-relay interop for now
daviddias cba1be2
adjust timeouts on sharding tests
daviddias 409a523
fix timouts on bitswap
daviddias ddcca8b
moar time
daviddias File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore
- Loading branch information
commit 18f5a9a7f51ef79fb51feb59f273218f863e434c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| const parallel = require('async/parallel') | ||
| const spawnTools = require('./test/utils/spawn-tools') | ||
| const js = spawnTools.spawnJsNode | ||
| const go = spawnTools.spawnGoNode | ||
| // const go = spawnTools.spawnGoNode | ||
| const stop = spawnTools.stopNodes | ||
|
|
||
| /* | ||
|
|
@@ -18,11 +18,11 @@ function pre (done) { | |
| (cb) => js([`${base}/10012`, `${base}/20012/ws`], true, 31012, 32012, cb), | ||
| (cb) => js([`${base}/10013`, `${base}/20013/ws`], true, 31013, 32013, cb), | ||
| (cb) => js([`${base}/10014`, `${base}/20014/ws`], true, 31014, 32014, cb), | ||
| (cb) => js([`${base}/10015`, `${base}/20015/ws`], true, 31015, 32015, cb), | ||
| (cb) => go([`${base}/10027`, `${base}/20027/ws`], true, 33027, 44027, cb), | ||
| (cb) => go([`${base}/10028`, `${base}/20028/ws`], true, 33028, 44028, cb), | ||
| (cb) => go([`${base}/10031`, `${base}/20031/ws`], true, 33031, 44031, cb), | ||
| (cb) => go([`${base}/10032`, `${base}/20032/ws`], true, 33032, 44032, cb) | ||
| (cb) => js([`${base}/10015`, `${base}/20015/ws`], true, 31015, 32015, cb) | ||
| // (cb) => go([`${base}/10027`, `${base}/20027/ws`], true, 33027, 44027, cb), | ||
| // (cb) => go([`${base}/10028`, `${base}/20028/ws`], true, 33028, 44028, cb), | ||
| // (cb) => go([`${base}/10031`, `${base}/20031/ws`], true, 33031, 44031, cb), | ||
| // (cb) => go([`${base}/10032`, `${base}/20032/ws`], true, 33032, 44032, cb) | ||
| ], done) | ||
| } | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why can't the "Spawner" use IPFS Factory?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, what are the magic numbers?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The numbers are the preexisting port numbers that this daemons were being started with - I kept them because I believe some other tests might rely on them. |
||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you make these spawn daemon tools part of test/utils? This file should have a very declarative feel and just inform the dev what is going to be spawned for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I'll move them over.