Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore
  • Loading branch information
daviddias committed Nov 8, 2017
commit 18f5a9a7f51ef79fb51feb59f273218f863e434c
12 changes: 6 additions & 6 deletions .aegir.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const parallel = require('async/parallel')
const spawnTools = require('./test/utils/spawn-tools')
const js = spawnTools.spawnJsNode
const go = spawnTools.spawnGoNode
// const go = spawnTools.spawnGoNode
const stop = spawnTools.stopNodes

/*
Expand All @@ -18,11 +18,11 @@ function pre (done) {
(cb) => js([`${base}/10012`, `${base}/20012/ws`], true, 31012, 32012, cb),
(cb) => js([`${base}/10013`, `${base}/20013/ws`], true, 31013, 32013, cb),
(cb) => js([`${base}/10014`, `${base}/20014/ws`], true, 31014, 32014, cb),
(cb) => js([`${base}/10015`, `${base}/20015/ws`], true, 31015, 32015, cb),
(cb) => go([`${base}/10027`, `${base}/20027/ws`], true, 33027, 44027, cb),
(cb) => go([`${base}/10028`, `${base}/20028/ws`], true, 33028, 44028, cb),
(cb) => go([`${base}/10031`, `${base}/20031/ws`], true, 33031, 44031, cb),
(cb) => go([`${base}/10032`, `${base}/20032/ws`], true, 33032, 44032, cb)
(cb) => js([`${base}/10015`, `${base}/20015/ws`], true, 31015, 32015, cb)
// (cb) => go([`${base}/10027`, `${base}/20027/ws`], true, 33027, 44027, cb),
// (cb) => go([`${base}/10028`, `${base}/20028/ws`], true, 33028, 44028, cb),
// (cb) => go([`${base}/10031`, `${base}/20031/ws`], true, 33031, 44031, cb),
// (cb) => go([`${base}/10032`, `${base}/20032/ws`], true, 33032, 44032, cb)
], done)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make these spawn daemon tools part of test/utils? This file should have a very declarative feel and just inform the dev what is going to be spawned for testing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I'll move them over.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't the "Spawner" use IPFS Factory?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what are the magic numbers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The numbers are the preexisting port numbers that this daemons were being started with - I kept them because I believe some other tests might rely on them.


Expand Down