chore: Upgrade github.com/cockroachdb/pebble/v2 to v2.0.6 for Go 1.25 support #10850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 tasks
Go 1.25 incompatibility detected in * Homebrew/homebrew-core#226636 then: * reported upstream in cockroachdb/swiss#48 * fixed upstream cockroachdb/swiss#49 This PR brings this fix upstream to kubo. The fix was brought to github.com/cockroachdb/pebble/v2 in * cockroachdb/pebble#4954 And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6 Which is now used. Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6
stefanb
changed the title
stefanb
changed the title
stefanb
changed the title
stefanb
changed the title
Contributor
|
I think this one would be bubbled by updating go-ds-pebble |
Contributor
Author
|
@hsanjuan yes, once |
Contributor
|
Added support for pebble v2.0.6 via Updated this PR to depend on go-ds-pebble v0.5.1 |
gammazero
approved these changes
Jul 2, 2025
Contributor
Author
|
Thanks, @gammazero! |
lidel
pushed a commit
that referenced
this pull request
Jul 8, 2025
… support (#10850) * Upgrade github.com/cockroachdb/swiss for Go 1.25 support Go 1.25 incompatibility detected in * Homebrew/homebrew-core#226636 then: * reported upstream in cockroachdb/swiss#48 * fixed upstream cockroachdb/swiss#49 This PR brings this fix upstream to kubo. The fix was brought to github.com/cockroachdb/pebble/v2 in * cockroachdb/pebble#4954 And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6 Which is now used. Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6 * Upgrade to go-ds-pebble v0.5.1 for pebbel v2.0.6 support --------- Co-authored-by: gammazero <[email protected]> (cherry picked from commit 6f0c1de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.25 incompatibility detected in
then:
The fix was brought to github.com/cockroachdb/pebble/v2 in
And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6
Which is now used in this PR.
Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6