BCN - PT - Cristina Hernández #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JdeJ
reviewed
Jun 11, 2019
| return a; | ||
| } else if (b > a) { | ||
| return b; | ||
| } else if (b === a) { |
There was a problem hiding this comment.
Si llega a este punto es que son iguales, con un simple else te vale.
JdeJ
reviewed
Jun 11, 2019
| } | ||
| return longestWord; | ||
| } | ||
|
|
There was a problem hiding this comment.
De aquí para abajo no se ejecuta, con el if else ya tienes todos los casos cubiertos.
JdeJ
reviewed
Jun 11, 2019
| return true; | ||
| } | ||
|
|
||
| for (k = 0; k <= wordArray.length; k++) { |
There was a problem hiding this comment.
Esto no se controla así, se produce un error al intentar acceder a una posición que no existe. Tiene que ser así:
for (let k = 0; k < wordArray.length; k++) {
JdeJ
reviewed
Jun 11, 2019
| "disobedience", | ||
| "matter" | ||
| ]; | ||
| function howManyTimes(arrayToCount, wordToCount) { |
|
Hola Cristina, cuando puedas tenemos que hablar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the delayed :( pero pasa todos los specs del test (menos bonus) fingers crossed para que no hayan muchos fallos...