Skip to content
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a7e2329
[#1587] Exclude a common part of CLI parser
fivitti Jan 2, 2025
ac04f65
[#1587] Working general CLI parser
fivitti Jan 3, 2025
ffd2cf4
[#1587] Fix the wrong argument
fivitti Jan 7, 2025
8808118
[#1587] Unify agent and server parsers
fivitti Jan 7, 2025
e301a43
[#1587] Verify the envvars
fivitti Jan 7, 2025
30c4d21
[#1587] Fix linter issues
fivitti Jan 7, 2025
c8ca1c5
[#1587] Verify system environment variables
fivitti Jan 7, 2025
81b857a
[#1587] Add unit tests
fivitti Jan 7, 2025
48add73
[#1587] Extend unit test
fivitti Jan 7, 2025
06ba0b6
[#1587] Fix unit tests
fivitti Jan 7, 2025
cfb6ec4
[#1587] Simplify utility
fivitti Jan 7, 2025
7a29eb8
[#1587] Fix linter issue
fivitti Jan 8, 2025
522be1b
[#1587] Remove redundant flags
fivitti Jan 8, 2025
c6657d4
[#1587] Add unit tests
fivitti Jan 8, 2025
bf98f00
[#1587] Add a Changelog entry
fivitti Jan 8, 2025
19b7c94
[#1587] Unify the CLI handling in the Stork tool
fivitti Jan 8, 2025
66db02f
[#1587] Move package
fivitti Jan 8, 2025
425910d
[#1587] Exclude app to a separate file
fivitti Jan 8, 2025
7b201bd
[#1587] Unexport structs
fivitti Jan 8, 2025
6569020
[#1587] Unify code-gen CLI
fivitti Jan 8, 2025
27c6b7c
[#1587] Remove unnecessary dependencies
fivitti Jan 8, 2025
185123d
[#1587] Rename structs
fivitti Jan 9, 2025
f1d16f2
[#1587] Add unit tests
fivitti Jan 9, 2025
60f2fe4
[#1587] Rephrase a sentence
fivitti Jan 9, 2025
1acfd8d
[#1587] Support hooks only for agent and server
fivitti Jan 9, 2025
9285a3c
[#1587] Add unit test
fivitti Jan 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[#1587] Extend unit test
  • Loading branch information
fivitti authored and tomaszmrugalski committed Jun 2, 2025
commit 48add7346fccfd2b5f638e068d5e9e2ad808d35f
7 changes: 4 additions & 3 deletions backend/appcfg/stork/cli_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ func TestVerifyEnvironmentFile(t *testing.T) {
envPath, _ := sandbox.Write("file.env", `
STORK_SERVER_TLS_CERT=tlsCert
STORK_SERVER_UNKNOWN=unknown
FOOBAR=foobar
`)

type settings struct {
Expand All @@ -459,9 +460,6 @@ STORK_SERVER_UNKNOWN=unknown

parser := NewCLIParser(flags.NewParser(data, flags.Default), "server", func() {})

// os.Setenv("STORK_SERVER_UNKNOWN", "unknown")
// os.Setenv("STORK_SERVER_TLS_CERT", "tlsCert")

// Act
var err error
stdout, _, captureErr := testutil.CaptureOutput(func() {
Expand All @@ -481,6 +479,7 @@ STORK_SERVER_UNKNOWN=unknown
)
require.Contains(t, string(stdout), expectedLog)
require.NotContains(t, string(stdout), "TLS_CERT")
require.Contains(t, string(stdout), "Unknown environment variable: 'FOOBAR'")
}

// Test that the unknown system-wide environment variables are logged and
Expand All @@ -499,6 +498,7 @@ func TestVerifySystemEnvironmentVariables(t *testing.T) {

os.Setenv("STORK_SERVER_UNKNOWN", "unknown")
os.Setenv("STORK_SERVER_TLS_CERT", "tlsCert")
os.Setenv("FOOBAR", "foobar")

// Act
stdout, _, captureErr := testutil.CaptureOutput(func() {
Expand All @@ -511,4 +511,5 @@ func TestVerifySystemEnvironmentVariables(t *testing.T) {
expectedLog := `Unknown environment variable: 'STORK_SERVER_UNKNOWN' set in a shell`
require.Contains(t, string(stdout), expectedLog)
require.NotContains(t, string(stdout), "TLS_CERT")
require.NotContains(t, string(stdout), "FOOBAR")
}