Skip to content

WIP noise annotation refactor #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from
Draft

WIP noise annotation refactor #69

Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
26213e5
Merge pull request #3 from opera-adt/main
seongsujeong Aug 8, 2022
8fddf15
Merge branch 'main' of github.com:opera-adt/s1-reader
seongsujeong Aug 9, 2022
dffe813
Replacing the loaders in Burst* class into class methods, with furthe…
seongsujeong Aug 10, 2022
0ec4fc4
fix on determining beta_naught; addressing PEP8 issues
seongsujeong Aug 10, 2022
b4d3c0e
Bug fix and feature addition to BurstEAP; restructuring LUT exportation
seongsujeong Aug 20, 2022
6d11d3d
Readibility improvement; removing unnecessary imports
seongsujeong Aug 24, 2022
460eecb
Merge branch 'main' of github.com:opera-adt/s1-reader
seongsujeong Aug 24, 2022
142ece4
Format change on `burst_id`; keeping the absolute orbit number inside…
seongsujeong Aug 24, 2022
bae4227
updates on test_bursts.py
seongsujeong Aug 25, 2022
5eb971b
Merge branch 'main' of github.com:opera-adt/s1-reader into burst_id_a…
seongsujeong Aug 25, 2022
45662ce
Merge branch 'burst_id_and_abs_orbit' into correction_and_calibration
seongsujeong Aug 25, 2022
83454cb
keeping the basename of the CADS and NADS for populating RTC metadata
seongsujeong Aug 25, 2022
b29ffe2
Update src/s1reader/s1_annotation.py
seongsujeong Aug 28, 2022
2ae4fa2
Update src/s1reader/s1_annotation.py
seongsujeong Aug 28, 2022
79a4f20
Update src/s1reader/s1_annotation.py
seongsujeong Aug 28, 2022
79032a4
Update src/s1reader/s1_annotation.py
seongsujeong Aug 28, 2022
de49003
Update src/s1reader/s1_burst_slc.py
seongsujeong Aug 28, 2022
9013e4f
Update src/s1reader/s1_burst_slc.py
seongsujeong Aug 28, 2022
64f34e0
Update src/s1reader/s1_burst_slc.py
seongsujeong Aug 28, 2022
e7df7b0
Update src/s1reader/s1_burst_slc.py
seongsujeong Aug 28, 2022
389aa53
Merge pull request #5 from opera-adt/main
seongsujeong Aug 28, 2022
bf029cc
Update src/s1reader/s1_burst_slc.py
seongsujeong Aug 28, 2022
b3f3612
Update src/s1reader/s1_burst_slc.py
seongsujeong Aug 28, 2022
f0b0b82
Update src/s1reader/s1_burst_slc.py
seongsujeong Aug 28, 2022
4109740
Update src/s1reader/s1_burst_slc.py
seongsujeong Aug 28, 2022
6d62feb
addressing comments bt @LiangJYu
seongsujeong Aug 28, 2022
df2b371
Merge branch 'correction_and_calibration' of github.com:seongsujeong/…
seongsujeong Aug 28, 2022
1af92bf
docstring fix; variables renamed for clarity
seongsujeong Aug 28, 2022
d9a76d9
implemented s1_annotation.AucCal.load_from_zip_file()
seongsujeong Aug 28, 2022
3504967
readability improvement
seongsujeong Aug 28, 2022
6b2a07a
s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8…
seongsujeong Aug 28, 2022
d5cd5de
docstring for `s1_burst_slc.eap_compensation_lut()`
seongsujeong Aug 28, 2022
db59419
class import scheme changed
seongsujeong Aug 28, 2022
e908892
PEP8 compliance
seongsujeong Aug 28, 2022
a9149e1
Update src/s1reader/s1_annotation.py
seongsujeong Aug 31, 2022
7fb70a4
Update src/s1reader/s1_annotation.py
seongsujeong Aug 31, 2022
53ffce4
Update src/s1reader/s1_annotation.py
seongsujeong Aug 31, 2022
0700e74
Update src/s1reader/s1_reader.py
seongsujeong Aug 31, 2022
fe8252e
Update src/s1reader/s1_reader.py
seongsujeong Aug 31, 2022
90c09bd
command and variable name revised for clarity
seongsujeong Aug 31, 2022
d87c234
Raise error when `burst_noise` is not defined but user attempts to re…
seongsujeong Aug 31, 2022
08acee0
fixing variable names that causing CircieCI to fail
seongsujeong Aug 31, 2022
27f6998
LUT retrieval scheme changed; updates in accordance with the comments…
seongsujeong Sep 6, 2022
637a7d5
Changing the length unit in BurstEAP._anx2roll() to [m]
seongsujeong Sep 6, 2022
9c13a08
change on variable name for clarity
seongsujeong Sep 6, 2022
265a6c2
Addressing PEP8 issue (R0201)
seongsujeong Sep 13, 2022
4aac153
Reverting the unit in `_anx2roll()` into the original documentataion;…
seongsujeong Sep 13, 2022
1b7f805
Update src/s1reader/s1_annotation.py
seongsujeong Sep 14, 2022
14e046c
Update src/s1reader/s1_annotation.py
seongsujeong Sep 14, 2022
69072d9
Update src/s1reader/s1_annotation.py
seongsujeong Sep 14, 2022
de4096e
Update src/s1reader/s1_annotation.py
seongsujeong Sep 14, 2022
663c735
Docstring clarification
seongsujeong Sep 14, 2022
90aa6d7
Addressing PEP8 C0301
seongsujeong Sep 14, 2022
2ce289a
AuxCal.get_aux_cal_instrument_config_id() - check the instrument conf…
seongsujeong Sep 14, 2022
2913b29
get_path_aux_cal() - check if the instrument configuration ID matches
seongsujeong Sep 14, 2022
f019bae
untested refactor to isolate noise loading from annotation
LiangJYu Sep 21, 2022
2a0c138
Merge branch 'main' into noise_refactor
LiangJYu Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/s1reader/s1_annotation.py 
Reverting the docstring to be split into two lines for PEP8 compliance

Co-authored-by: Liang Yu <[email protected]>
  • Loading branch information
@seongsujeong @LiangJYu
seongsujeong and LiangJYu authored Aug 28, 2022
commit 79a4f2078e1e66bc14f6be68196de5ccba1ece31
2 changes: 1 addition & 1 deletion src/s1reader/s1_annotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ def from_calibration_annotation(cls, calibration_annotation: CalibrationAnnotati

@dataclass
class BurstEAP:
'''EAP correction information for Sentinel-1 IW SLC burst
'''Elevation antenna pattern (EAP) correction information for Sentinel-1 IW SLC burst
'''
#from LADS
Ns: int # number of samples
Expand Down