Skip to content

testcase and fix for issue #1459 (BoundingSphere merge yields NaNs) #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2021
Merged

testcase and fix for issue #1459 (BoundingSphere merge yields NaNs) #1465

merged 2 commits into from
Feb 18, 2021

Conversation

stephengold
Copy link
Member

No description provided.

@stephengold stephengold added this to the Future Release milestone Feb 2, 2021
@stephengold
Copy link
Member Author

I decided that the overflow in Vector3f.length() is part of the issue, so fixing it should be part of this PR. Switching to "draft" mode.

@stephengold stephengold marked this pull request as draft February 4, 2021 17:34
@stephengold stephengold marked this pull request as ready for review February 4, 2021 18:56
@stephengold stephengold merged commit 6b829c6 into jMonkeyEngine:master Feb 18, 2021
@stephengold stephengold deleted the sgold-issue-1459 branch February 20, 2021 20:51
@stephengold stephengold modified the milestones: Future Release, v3.4.0 Feb 20, 2021
@stephengold stephengold linked an issue Mar 16, 2021 that may be closed by this pull request
merging an infinite BoundingSphere with itself yields invalid result #1459
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

merging an infinite BoundingSphere with itself yields invalid result
1 participant
@stephengold