Android native sound fix and update openal-soft to 1.21.1

[joliver82]

This PR fixes issue #1239 (both sound not working and ogg files not loaded).

Also this PR updates openal-soft to latest (1.21.1).

EDIT: I saw it's failing to compile. Maybe this is caused by an old release of the ndk, I'm using latest (22)

[Ali-RS]

Thanks, @joliver82

By the way, what is bsinc_inc.h for?

[joliver82]

bsinc_inc.h is an autogenerated header file for openal-soft 1.19.1 (see commit joliver82@fc99412) for 1.21.1 is useless and I've just removed it

[MeFisto94]

Well, you bumped the Target Version from 9 to 19, so that certainly requires a more recent NDK.
It may be worth asking @riccardobl to update

jmonkeyengine/.github/workflows/main.yml

Line 64 in fc8128c

image: riccardoblb/buildenv-jme3:android

and it's integrated NDK version.

This is something that may even fix the compiler issues.
The "optimal" solution here would be to look at the relevant bytecode and find out why optimization fails, maybe with the help of some clang/gcc guys. Maybe we can make it more clear from the source code to prevent that issue, if it's not fixed in a more recent version already.

I mean the compiler shouldn't like change values into -1 randomly.
That may however be done after this workaround, but having Optimizations, especially on mobile devices, is a good idea.

Regarding the build failures, the first one is /opt/android/ndk-bundle/build/ndk-build: line 148: file: command not found
And then: https://stackoverflow.com/questions/64281680/error-no-template-named-enable-if-t-in-namespace-std-did-you-mean-enable
-> As the Warnings also indicate, we need to enable the C++14 featureset, which may or may not already work with that NDK version, given the correct flags

[joliver82]

Android api level 19 stands for kitkat 4.4 which was released on 2013 so I assume riccardobl's image is new enough to support it.

I agree that it would be better to properly fix this keeping optimizations enabled but I'm not that good at C/C++ and I didn't want to change code from external libraries (the issues are located at tremor and openal-soft)

About C++14, if setting any -str=c++* flag ndk-build fails because there're plain C files (com_jme3_*.c) in the same library, that's why I didn't. Also it compiled properly in ndk 22

EDIT:

the line 148 at ndk-build is caused because "file" is not installed in the docker image:
line 148: file -L "$SHELL" | grep -q "x86[_-]64"

The ndk in the image is 20.0.5594570, in fact updating the ndk succeeded to compile it. I've been reading about this and although c++14 is supported and is clang's default, it was not working this way in ndk till r21:

https://github.com/android/ndk/wiki/Changelog-r21
--> Fixed ndk-build to use Clang's default C++ standard version (currently C++14) when using libc++.

it would be great if @riccardobl could just rebuild the riccardoblb/buildenv-jme3:android docker image so we would use latest ndk to build jme3 android natives (and also add file package to avoid the ndk line 148 error)

[Ali-RS]

it would be great if @riccardobl could just rebuild the riccardoblb/buildenv-jme3:android docker image so we would use latest ndk to build jme3 android natives (and also add file package to avoid the ndk line 148 error)

I am not familiar with JME's build env but can this be configured from https://github.com/jMonkeyEngine/buildenv-jme3?

And about this:

jmonkeyengine/.github/workflows/main.yml

Line 64 in fc8128c

image: riccardoblb/buildenv-jme3:android

Should we change it to use jmonkeyengine/buildenv-jme3:android? (https://hub.docker.com/r/jmonkeyengine/buildenv-jme3)

[riccardobl]

it would be great if @riccardobl could just rebuild the riccardoblb/buildenv-jme3:android docker image so we would use latest ndk to build jme3 android natives (and also add file package to avoid the ndk line 148 error)

I am not familiar with JME's build env but can this be configured from https://github.com/jMonkeyEngine/buildenv-jme3?

And about this:

jmonkeyengine/.github/workflows/main.yml

Line 64 in fc8128c

image: riccardoblb/buildenv-jme3:android

Should we change it to use jmonkeyengine/buildenv-jme3:android? (https://hub.docker.com/r/jmonkeyengine/buildenv-jme3)

Yes. It should be changed to jmonkeyengine/buildenv-jme3:android (from https://hub.docker.com/u/jmonkeyengine) .
As you have noticed I mirrored my repo to the jme org, but i've never actually changed the references in the build script.

[joliver82]

I just changed it. The image was built 12 days ago, so it should have latest ndk and compile properly

[MeFisto94]

Well it is based on https://github.com/jMonkeyEngine/buildenv-jme3/blob/f6a80d1bf5ae39746b84b2391d9ebb28135b3168/android/Dockerfile, so it should be recent enough

[Ali-RS]

Note that /opt/android/ndk-bundle/build/ndk-build: line 151: file: command not found is still happening. In case this is still an issue!

[joliver82]

Not a real issue, but I'll add file package to the docker image later

[Ali-RS]

Thanks

[stephengold]

Is this PR ready to be integrated?

[joliver82]

Note that /opt/android/ndk-bundle/build/ndk-build: line 151: file: command not found is still happening. In case this is still an issue!

Created a PR for buildenv to fix this (jMonkeyEngine/buildenv-jme3#1)

Is this PR ready to be integrated?

From my point of view, it is