solve issue #2366 (bugs related to saving/loading a Spline) #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plan to merge this PR in 24 hours. |
|
Oops, I said i'd merge in 24 hours... 2 weeks ago. Sorry for the delay! |
As a former release manager, I understand that life doesn't always go according to plan. No harm done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves issue #2366 and adds an automated test to prevent regressions.
The issue of spines being loaded as the wrong type is solved by passing the same tag ("type") to
readEnum()as was passed tooc.write().The
ClassCastExceptionissue is solved by convertingknotsto/from afloat[]array and saving/loading those arrays. Compatibility with serialized data from past releases is maintained in the case whereknotsisnull---in other words for non-NURB splines. However, past releases couldn't serialize NURB splines without crashing, so this change shouldn't cause any issues in practice.