Feature/sites #17
Merged
Feature/sites #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not checked or not properly filled.
… so user doesn't need to click enter to unlock Upload button, and making sure that value is there.
Closed
Contributor
|
@adku Do you want to resolve the conflicts on this PR? The storyboard conflict is probably simpler to just delete your changes, and recreate the changes from the master branch storyboard. Otherwise, I can take your code changes into a branch of my own and reapply the storyboard changes. |
…d resolved conflicts
Contributor
Author
|
@macblazer |
macblazer
reviewed
May 6, 2020
| } | ||
| } | ||
|
|
||
| func updateSiteUI() { |
Contributor
There was a problem hiding this comment.
Since this project makes heavy use of bindings, if you wanted to you could remove this hide/show logic from the code and use bindings on the labels' Hidden property, and tie it to the Site checkbox state.
macblazer
approved these changes
May 6, 2020
Contributor
macblazer
left a comment
macblazer
left a comment
There was a problem hiding this comment.
The code seems to work as is. One minor adjustment perhaps.
mm512
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done: #12