Release 1.2.1 finishing touches #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er will at least know there was an error.
…2.1-finishing-touches
kkot
approved these changes
Sep 16, 2020
| errMessage = "Unknown error: \(statusCode)" | ||
| } | ||
| print(errMessage) | ||
| Alert().display(header: "Upload failed", message: errMessage) |
There was a problem hiding this comment.
Suggested change
| Alert().display(header: "Upload failed", message: errMessage) | |
| Alert().display(header: "Upload failed:", message: errMessage) |
There was a problem hiding this comment.
I don't think we want a colon at the end of the header. The header describes the situation on one line, and then the message gives more detail, and the message already has a colon, so it would look strange to have two colons.
There was a problem hiding this comment.
I just saw that there is a colon in other messages for example "Attention:".
There was a problem hiding this comment.
Ah dang, I didn't notice it there.
hisaac
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ended up getting the internal build working again and didn't have any other changes except one to add some errors for when the upload to the server fails.
The error message is in HTML but better than nothing? If anyone wants to do something more, feel free. Otherwise, this last change is probably good and we can release 1.2.1