Skip to content

Drag and drop of applications now accepts multiple apps (#85) #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Drag and drop of applications now accepts multiple apps (#85) #94

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
620c325
Added support for multiple files during a drop operation for the appl…
macblazer Apr 7, 2021
f26b691
Fixed some whitespace issues detected by Swiftlint in the ModelTests.…
macblazer Apr 7, 2021
f1a2422
#85 Add to CHANGELOG.md, and added the CHANGELOG.md to the Xcode proj…
macblazer Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed some whitespace issues detected by Swiftlint in the ModelTests.… 
…swift file.
  • Loading branch information
@macblazer
macblazer committed Apr 7, 2021
commit f26b6913c59d34b251694560f57637739e7b82aa
36 changes: 18 additions & 18 deletions PPPC UtilityTests/ModelTests/ModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,87 +42,87 @@ class ModelTests: XCTestCase {
// MARK: - tests for getExecutableFrom*

func testGetExecutableBasedOnIdentifierAndCodeRequirement_BundleIdentifierType() {
//given
// given
let identifier = "com.example.App"
let codeRequirement = "testCodeRequirement"

//when
// when
let executable = model.getExecutableFrom(identifier: identifier, codeRequirement: codeRequirement)

//then
// then
XCTAssertEqual(executable.displayName, "App")
XCTAssertEqual(executable.codeRequirement, codeRequirement)
XCTAssertEqual(executable.iconPath, IconFilePath.application)
}

func testGetExecutableBasedOnIdentifierAndCodeRequirement_PathIdentifierType() {
//given
// given
let identifier = "/myGreatPath/Awesome/Binary"
let codeRequirement = "testCodeRequirement"

//when
// when
let executable = model.getExecutableFrom(identifier: identifier, codeRequirement: codeRequirement)

//then
// then
XCTAssertEqual(executable.displayName, "Binary")
XCTAssertEqual(executable.codeRequirement, codeRequirement)
XCTAssertEqual(executable.iconPath, IconFilePath.binary)
}

func testGetExecutableFromComputerBasedOnIdentifier() {
//given
// given
let identifier = "com.apple.Safari"
let codeRequirement = "randomReq"

//when
// when
let executable = model.getExecutableFrom(identifier: identifier, codeRequirement: codeRequirement)

//then
// then
XCTAssertEqual(executable.displayName, "Safari")
XCTAssertNotEqual(executable.iconPath, IconFilePath.application)
XCTAssertNotEqual(codeRequirement, executable.codeRequirement)
}

func testGetExecutableFromSelectedExecutables() {
//given
// given
let expectedIdentifier = "com.something.1"
let executable = model.getExecutableFrom(identifier: expectedIdentifier, codeRequirement: "testReq")
let executableSecond = model.getExecutableFrom(identifier: "com.something.2", codeRequirement: "testReq2")
model.selectedExecutables = [executable, executableSecond]

//when
// when
let existingExecutable = model.getExecutableFromSelectedExecutables(bundleIdentifier: "com.something.1")

//then
// then
XCTAssertNotNil(existingExecutable)
XCTAssertEqual(existingExecutable?.identifier, expectedIdentifier)
XCTAssertEqual(existingExecutable?.displayName, "1")
XCTAssertEqual(existingExecutable?.iconPath, IconFilePath.application)
}

func testGetExecutableFromSelectedExecutables_Path() {
//given
// given
let expectedIdentifier = "/path/something/Special"
let executableOneMore = model.getExecutableFrom(identifier: "/path/something/Special1", codeRequirement: "testReq")
let executable = model.getExecutableFrom(identifier: expectedIdentifier, codeRequirement: "testReq")
let executableSecond = model.getExecutableFrom(identifier: "com.something.2", codeRequirement: "testReq2")
model.selectedExecutables = [executableOneMore, executable, executableSecond]

//when
// when
let existingExecutable = model.getExecutableFromSelectedExecutables(bundleIdentifier: "/path/something/Special")

//then
// then
XCTAssertNotNil(existingExecutable)
XCTAssertEqual(existingExecutable?.identifier, expectedIdentifier)
XCTAssertEqual(existingExecutable?.displayName, "Special")
XCTAssertEqual(existingExecutable?.iconPath, IconFilePath.binary)
}

func testGetExecutableFromSelectedExecutables_Empty() {
//when
// when
let existingExecutable = model.getExecutableFromSelectedExecutables(bundleIdentifier: "com.something.1")

//then
// then
XCTAssertNil(existingExecutable)
}

Expand Down Expand Up @@ -185,7 +185,7 @@ class ModelTests: XCTestCase {
}
}

//swiftlint:disable:next function_body_length
// swiftlint:disable:next function_body_length
func testExportProfileWithAppleEventsAndLegacyAllowed() {
// given
let exe1 = Executable(identifier: "one", codeRequirement: "oneReq")
Expand Down