Skip to content

Fixes a perf issue in GetContentsByStream() #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes a perf issue in GetContentsByStream() #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions source/CsQuery/HtmlParser/ElementFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,17 +507,17 @@ private TextReader GetContextFromStream(TextReader reader, out string context)
{

int pos = 0;
string tag = "";
string readSoFar = "";
StringBuilder tag = new StringBuilder();
StringBuilder readSoFar = new StringBuilder();
int mode=0;
char[] buf = new char[1];
bool finished = false;

while (!finished && reader.Read(buf,0,1)>0)
{

char cur = buf[0];
readSoFar += cur;
readSoFar.Append(cur);

switch(mode) {
case 0:
Expand All @@ -531,13 +531,13 @@ private TextReader GetContextFromStream(TextReader reader, out string context)
finished = true;
break;
}
tag += cur;
tag.Append(cur);
break;
}
pos++;
}
context = GetContext(tag);
return new CombinedTextReader(new StringReader(readSoFar), reader);
context = GetContext(tag.ToString());
return new CombinedTextReader(new StringReader(readSoFar.ToString()), reader);
}

private void InitializeTreeBuilder()
Expand Down